This patch ports the appmenu applet to use
libtaskmanager.
Details
Details
- Reviewers
broulik - Group Reviewers
Plasma - Commits
- R120:d8d079e42e62: [applets/appmenu] Use libtaskmanager for appmenus
Ensure that there aren't any regressions.
Diff Detail
Diff Detail
- Repository
- R120 Plasma Workspace
- Branch
- appmenu-use-libtm (branched from master)
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 23957 Build 23975: arc lint + arc unit
Comment Actions
I love patches with a lot of red!
When filtering by screen, this now means we get appmenu only when the active window is on the same screen? Not sure if this is what we want?
(Perhaps we could do some clever "last window with menu" tracking so we can have per-screen global menu? :D)
| applets/appmenu/lib/CMakeLists.txt | ||
|---|---|---|
| 15 | Unused | |
| applets/appmenu/plugin/appmenumodel.cpp | ||
| 68–69 | Is this needed? I would think if screen geometry changes, task manager updates and filters and signals the active task having changed? | |
| 144 | Remove | |
| 146–148 | Please write as const QModelIndex activeTaskIdx = m_tasksMode->activeTask(); const QString objectPath = m_tasksModel->data(activeTaskIdx, TaskManager::AbstractTasmsModel::ApplicationMenuObjectPath).toString(); const QString serviceName = ....; (perhaps you could drop a using namespace TaskManager at the top of the cpp file) | |
| 150–153 | !objectPath.isEmpty() | |
| applets/appmenu/plugin/appmenumodel.h | ||
| 88 | I think you can remove this member now and just forward to tasksmodel | |
| applets/appmenu/lib/CMakeLists.txt | ||
|---|---|---|
| 15 | Linkage fails without it. | |