Details
- Reviewers
aacid - Commits
- R49:158d89b44eb3: Fix GCC8 warnings
Diff Detail
- Repository
- R49 KCacheGrind
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
libcore/cachegrindloader.cpp | ||
---|---|---|
1087 | H-m-m... Can you provide a recipe to build the current git/master with Qt 4? In CMakeLists.txt, set (QT_MIN_VERSION "5.2.0") https://cgit.kde.org/kcachegrind.git/tree/CMakeLists.txt#n6 In qcg.pro, lessThan(QT_MAJOR_VERSION, 5) { error("QCachegrind requires Qt 5.3 or greater") } https://cgit.kde.org/kcachegrind.git/tree/qcg.pro#n6 It seems to me that it is only possible to build with Qt 5 these days. |
libcore/cachegrindloader.cpp | ||
---|---|---|
1087 | Then you should update the README :) Anyway, Q_FALLTHROUGH was introduced in Qt 5.8, so you still can't use it. |
libcore/cachegrindloader.cpp | ||
---|---|---|
1087 | A proper comment like |
Sorry for my late reaction.
Yes, current master only supports Qt5; Yuri, thanks for updating the README!
Adding the "break" is correct. It just did never triggered as summary lines do not
contain the text "calls=".
And good to know that GCC catches "fall through" comments, if correctly written.