Improve results and result's items code
ClosedPublic
Actions

Authored by sirgienko on Oct 5 2018, 5:42 PM.

Details

Reviewers

asemke
filipesaraiva

Commits

R55:4d95d41af1de: Improve results and result's items code - Add support for removing one of…

Summary

Add support for removing one of multiple results
Move remove slot to base class (ResultItem)
Replace updateFromResult by update

Diff Detail

Repository

R55 Cantor

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

sirgienko created this revision.Oct 5 2018, 5:42 PM

Restricted Application added a project: KDE Edu. · View Herald TranscriptOct 5 2018, 5:42 PM

Restricted Application added a subscriber: kde-edu. · View Herald Transcript

sirgienko requested review of this revision.Oct 5 2018, 5:42 PM

Harbormaster completed remote builds in B3528: Diff 42939.Oct 5 2018, 5:42 PM

This resulting code looks ugly, so @asemke, @filipesaraiva I am open to suggestions.

Rewrite the patch according new @asemke changes

Harbormaster completed remote builds in B3882: Diff 43621.Oct 14 2018, 8:23 PM

sirgienko retitled this revision from Add support for result removing, when there are multiple results. to Improve results and result's items code.Oct 15 2018, 1:02 PM

sirgienko edited the summary of this revision. (Show Details)

asemke accepted this revision.Oct 16 2018, 7:34 PM

This revision is now accepted and ready to land.Oct 16 2018, 7:34 PM

Closed by commit R55:4d95d41af1de: Improve results and result's items code - Add support for removing one of… (authored by sirgienko). · Explain WhyOct 16 2018, 7:49 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/animationresultitem.h (7 lines)
M			src/animationresultitem.cpp (21 lines)
M			src/commandentry.h (4 lines)
M			src/commandentry.cpp (26 lines)
M			src/imageresultitem.h (7 lines)
M			src/imageresultitem.cpp (25 lines)
M			src/lib/expression.h (17 lines)
M			src/lib/expression.cpp (14 lines)
M			src/resultitem.h (12 lines)
M			src/resultitem.cpp (29 lines)
M			src/textresultitem.h (7 lines)
M			src/textresultitem.cpp (25 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	42939	8367cda		Oct 5 2018, 5:40 PM	★	★
Diff 2	43621	48e9b9a	Rewrite the patch according new @asemke changes	Oct 14 2018, 8:23 PM	★	★
Diff 3	43755	d5c18c1	R55:4d95d41af1de99bf7828a2138e0a2396c29790a7	Oct 16 2018, 7:45 PM	★	★