Display the window which users can input the name and select the list of project in order to create new template
Details
Details
Diff Detail
Diff Detail
- Repository
- R4 Zanshin
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Comment Actions
First of all, there are not test at all to cover this up, do you guys plan to bring them in later ? should be pushed at the same time so It would be easier for me to grasp how your whole mechanism is supposed to work (test is a spec too!). I'll apply this patch later to see what it looks like tho.
Comment Actions
The dialog is still not working at that point since you don't produce a project list model yet as advised last week. Did you look at TaskListModel as I proposed? Really you simply need to write a ProjectListModel...
Also I think the whole part about TemplatePageModel has no place at this stage, you're still trying to create a template from a project (from the story you're working on), not to list a template content yet.
| src/presentation/applicationmodel.h | ||
|---|---|---|
| 34 | This change is unneeded. | |
| 50 | "availableProjectTemplates" would be a better name | |
| 62 | Ditto. | |
| 78 | Rename to m_availableProjectTemplates. | |
| src/presentation/templatepagemodel.h | ||
| 3–4 | Copyright is wrong in this file, you wrote it, put the real authors. | |
| 44 | Are you creating this TemplatePageModel to display the content of a template? If yes, then I would expect the first argument to be a "Domain::Template::Ptr", this type obviously doesn't exist yet. Up to you to turn it into reality. | |
| 45–48 | Similarly those are probably the wrong queries and repositories... you would need to introduce your own to list templates and their content. | |
| src/widgets/availablepagesview.cpp | ||
| 63 | Remove that empty line | |
| 293 | m_projects is still a null pointer at that point. You need to initialize it with a model wrapping a list of projects. So you're missing a class inheriting from QAbstractItemModel for that... again TaskListModel would be a good inspiration for you to start from. | |
| 399 | Remove that empty line. | |
| src/widgets/availablepagesview.h | ||
| 86 | The name looks wrong, you're not providing a list here. | |
| src/widgets/newtemplatedialog.cpp | ||
| 3 | I didn't write that file either. | |
| src/widgets/newtemplatedialog.h | ||
| 3 | Fix the copyright line, I didn't write that file. | |
| src/widgets/newtemplatedialoginterface.cpp | ||
| 3 | I didn't write that file. | |
| src/widgets/newtemplatedialoginterface.h | ||
| 3 | I didn't write that file. | |