Details
Details
- Reviewers
sandroandrade
Diff Detail
Diff Detail
- Repository
- R163 Minuet
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Comment Actions
Please make the slight change required and ship it.
src/midisequencer.cpp | ||
---|---|---|
182 | You don't actually need to check this but it's useful to have it here since when playing MIDI files setSong is called when opening the file. Removing that would make setSong be invoked every time the playing is started and that isn't needed at all. | |
183 | Change it to: if(m_midiSequencerOutputThread->getInitialPosition() == 0 || !m_midiSequencerOutputThread->hasNext())) for sake of clarity. Change that and SHIP IT. |