Improve the problems tool view BUG:339839
ClosedPublic

Authored by Sergobot on Jan 12 2016, 11:54 PM.

Details

Summary

Remove text in "Error", "Warning" and "Hint" buttonsi and move them from the pop-up menu. Add current scope setting to the "Scope" button.

Test Plan

Tests passed; works as expected.

Diff Detail

Repository
R33 KDevPlatform
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Sergobot updated this revision to Diff 1910.Jan 12 2016, 11:54 PM
Sergobot retitled this revision from to Improve the problems tool view BUG:339839.
Sergobot updated this object.
Sergobot edited the test plan for this revision. (Show Details)
Sergobot added a reviewer: kfunk.
Sergobot added a subscriber: kdevelop-devel.
Sergobot changed the visibility from "Public (No Login Required)" to "KDevelop (Project)".
Sergobot changed the edit policy from "All Users" to "KDevelop (Project)".
Sergobot added a subscriber: KDevelop.
kfunk changed the visibility from "KDevelop (Project)" to "Public (No Login Required)".Jan 13 2016, 6:52 AM
kfunk changed the edit policy from "KDevelop (Project)" to "All Users".
kfunk edited edge metadata.

@Sergobot Note: Please keep the default access/edit policy

kfunk accepted this revision.Jan 13 2016, 6:57 AM
kfunk edited edge metadata.

LGTM, please push to 5.0 branch

Also add CCBUG: <bugnum to the commit message before pushing.

plugins/problemreporter/problemtreeview.cpp
313

Hm, you could use QObject::sender() here for retrieving the action, but it doesn't matter much.

plugins/problemreporter/problemtreeview.h
67

No const when passing POD values by value

This revision is now accepted and ready to land.Jan 13 2016, 6:57 AM
This revision was automatically updated to reflect the committed changes.