Don't crash if no fallback collection is found
ClosedPublic
Actions

Authored by ervin on Dec 27 2015, 9:30 PM.

Details

Reviewers

bensi
franckarrecot

Commits

R4:db64840af51b: Don't crash if no fallback collection is found

Summary

Bad bad me for dereferencing an iterator straight out of find_if. Indeed
maybe nothing match the criterion in which case we would crash. Could
happen on some systems on first use, it's a rare case but no need to die
just for that. :-)

Diff Detail

Repository

R4 Zanshin

Lint

Lint Skipped

Unit

Unit Tests Skipped

ervin updated this revision to Diff 1636.Dec 27 2015, 9:30 PM

ervin retitled this revision from to Don't crash if no fallback collection is found.

ervin updated this object.

ervin edited the test plan for this revision. (Show Details)

ervin added reviewers: bensi, franckarrecot.

bensi accepted this revision.Dec 28 2015, 10:48 AM

bensi edited edge metadata.

This revision is now accepted and ready to land.Dec 28 2015, 10:48 AM

Closed by commit R4:db64840af51b: Don't crash if no fallback collection is found (authored by ervin). · Explain WhyDec 28 2015, 8:58 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/akonadi/akonadinoterepository.cpp (17 lines)
M			src/akonadi/akonaditaskrepository.cpp (17 lines)
M			tests/units/akonadi/akonadinoterepositorytest.cpp (43 lines)
M			tests/units/akonadi/akonaditaskrepositorytest.cpp (44 lines)