Differential D4588

Fix the hardcoded include in lua backend
ClosedPublic
Actions

Authored by mva on Feb 12 2017, 9:14 PM.

Details

Reviewers
filipesaraiva
Group Reviewers
Cantor
Commits
R55:0b6f7a5721e7: Fix the hardcoded include for lua backend
Summary

This patch was provide by Vadim A. Misbakh-Soloviov (mva) in this link. The bug was reported by the author in #354772.

The title explains the bug.

Diff Detail

Repository
R55 Cantor
Lint
Lint Skipped
Unit
Unit Tests Skipped
filipesaraiva updated this revision to Diff 11245.Feb 12 2017, 9:14 PM
filipesaraiva retitled this revision from to Fix the hardcoded include in lua backend.
filipesaraiva updated this object.
filipesaraiva edited the test plan for this revision. (Show Details)
filipesaraiva added a reviewer: Cantor.
filipesaraiva set the repository for this revision to R55 Cantor.
filipesaraiva added a project: Cantor.
filipesaraiva added a subscriber: Cantor.
filipesaraiva added a subscriber: mva.Feb 12 2017, 9:19 PM

Please @mva, do the action "Commandeer Revision" in this bug report, so I can review it properly.

mva commandeered this revision.Feb 12 2017, 9:46 PM
mva added a reviewer: filipesaraiva.
filipesaraiva accepted this revision.Feb 15 2017, 1:11 AM
filipesaraiva edited edge metadata.

Thanks @mva. Unfortunately I can not test it with a different version of luajit (in Mageia the version is 2.0 yet) but everything looks like correct.

Please, push it. If you don't have a developer account and if you wish, provide me a name and an e-mail so I can use it in --author option of git commit.

This revision is now accepted and ready to land.Feb 15 2017, 1:11 AM
mva added a comment.Feb 15 2017, 6:05 AM

Hi!

Unfortunately, I've no developer account and push access (although, I'd like to get it, if it will not take too much time).

But, you can add "Vadim A. Misbakh-Soloviov <git@mva.name>" as "--author" when commiting. I hope, it is okay that my git email differs from my KDE Identity...

Closed by commit R55:0b6f7a5721e7: Fix the hardcoded include for lua backend (authored by mva, committed by filipesaraiva). · Explain WhyFeb 15 2017, 6:34 PM
This revision was automatically updated to reflect the committed changes.
filipesaraiva added a comment.Feb 15 2017, 6:39 PM

Thanks @mva and welcome to KDE community! :)

If you wish to stay with us for more time, please continue to provide patches, submit/fix bugs, etc, so we can to ask for a developer account for you. It is common in KDE community wait to see if the contributor wants work for more time before apply to a developer account.

Anyway, the commit was pushed using your data.

Cheers.

Revision Contents
Changeset List

Diff 11245

View Options

cmake/FindLuaJIT.cmake

Loading...
View Options

src/backends/lua/luaexpression.cpp

Loading...
View Options

src/backends/lua/luahelper.cpp

Loading...
View Options

src/backends/lua/luasession.h

Loading...