Changeset View
Changeset View
Standalone View
Standalone View
applet/contents/ui/ListItemBase.qml
| Show First 20 Lines • Show All 113 Lines • ▼ Show 20 Line(s) | 109 | PlasmaComponents.ToolButton { | |||
|---|---|---|---|---|---|
| 114 | iconName: "application-menu" | 114 | iconName: "application-menu" | ||
| 115 | onClicked: contextMenu.show(x, y + height) | 115 | onClicked: contextMenu.show(x, y + height) | ||
| 116 | } | 116 | } | ||
| 117 | } | 117 | } | ||
| 118 | 118 | | |||
| 119 | RowLayout { | 119 | RowLayout { | ||
| 120 | PlasmaCore.IconItem { | 120 | PlasmaCore.IconItem { | ||
| 121 | readonly property bool isPlayback: type.substring(0, 4) == "sink" | 121 | readonly property bool isPlayback: type.substring(0, 4) == "sink" | ||
| 122 | Layout.maximumHeight: slider.height * 0.85 | 122 | roundToIconSize: false | ||
| 123 | Layout.maximumWidth: slider.height * 0.85 | 123 | Layout.preferredWidth: Math.round(slider.height * 0.95) | ||
romangg: Why still the 0.95? Couldn't you just use the slider height? It's still a little bit small for… | |||||
Because slider.height is already too big (it's like half of the main device/app icon size). We should change the microphone-sensitivity icons to look same as the 16px version (sound "lines" are next to the microphone, not above). drosca: Because `slider.height` is already too big (it's like half of the main device/app icon size). | |||||
Ok, ship it. To still easily distinguish the two icons we could place the sound lines on the left side of the microphone and not on the right side like for the speaker. @andreask, could you take a look at that? romangg: Ok, ship it. To still easily distinguish the two icons we could place the sound lines on the… | |||||
I don't think placing the lines on the other side is the way to go. I created bug: https://bugs.kde.org/show_bug.cgi?id=377012 drosca: I don't think placing the lines on the other side is the way to go. I created bug: https://bugs. | |||||
| 124 | Layout.preferredHeight: Layout.preferredWidth | ||||
| 124 | source: Icon.name(Volume, Muted, isPlayback ? "audio-volume" : "microphone-sensitivity") | 125 | source: Icon.name(Volume, Muted, isPlayback ? "audio-volume" : "microphone-sensitivity") | ||
| 125 | 126 | | |||
| 126 | MouseArea { | 127 | MouseArea { | ||
| 127 | anchors.fill: parent | 128 | anchors.fill: parent | ||
| 128 | onPressed: Muted = !Muted | 129 | onPressed: Muted = !Muted | ||
| 129 | } | 130 | } | ||
| 130 | } | 131 | } | ||
| 131 | 132 | | |||
| ▲ Show 20 Lines • Show All 177 Lines • Show Last 20 Lines | |||||
Why still the 0.95? Couldn't you just use the slider height? It's still a little bit small for the microphone icon (especially showing the red line above as the difference between muted and unmuted)