Applet: Make volume indicator icon bigger
ClosedPublic

Authored by drosca on Feb 28 2017, 10:50 AM.

Details

Summary

There were complaints that the icon is too small, so make it bigger.

Diff Detail

Repository
R115 Plasma Audio Volume Applet
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
drosca created this revision.Feb 28 2017, 10:50 AM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 28 2017, 10:50 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
romangg accepted this revision.Feb 28 2017, 11:02 AM
romangg added a subscriber: romangg.
romangg added inline comments.
applet/contents/ui/ListItemBase.qml
123

Why still the 0.95? Couldn't you just use the slider height? It's still a little bit small for the microphone icon (especially showing the red line above as the difference between muted and unmuted)

This revision is now accepted and ready to land.Feb 28 2017, 11:02 AM
drosca added inline comments.Feb 28 2017, 11:12 AM
applet/contents/ui/ListItemBase.qml
123

Because slider.height is already too big (it's like half of the main device/app icon size).

We should change the microphone-sensitivity icons to look same as the 16px version (sound "lines" are next to the microphone, not above).

romangg added inline comments.
applet/contents/ui/ListItemBase.qml
123

Ok, ship it. To still easily distinguish the two icons we could place the sound lines on the left side of the microphone and not on the right side like for the speaker. @andreask, could you take a look at that?

drosca added inline comments.Feb 28 2017, 11:36 AM
applet/contents/ui/ListItemBase.qml
123

I don't think placing the lines on the other side is the way to go. I created bug: https://bugs.kde.org/show_bug.cgi?id=377012

This revision was automatically updated to reflect the committed changes.