There were complaints that the icon is too small, so make it bigger.
Details
Details
- Reviewers
romangg - Group Reviewers
Plasma - Commits
- R115:7b6c94185164: Applet: Make volume indicator icon bigger
R994:7b6c94185164: Applet: Make volume indicator icon bigger
Diff Detail
Diff Detail
- Repository
- R115 Plasma Audio Volume Applet
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
applet/contents/ui/ListItemBase.qml | ||
---|---|---|
123 | Why still the 0.95? Couldn't you just use the slider height? It's still a little bit small for the microphone icon (especially showing the red line above as the difference between muted and unmuted) |
applet/contents/ui/ListItemBase.qml | ||
---|---|---|
123 | Because slider.height is already too big (it's like half of the main device/app icon size). We should change the microphone-sensitivity icons to look same as the 16px version (sound "lines" are next to the microphone, not above). |
applet/contents/ui/ListItemBase.qml | ||
---|---|---|
123 | I don't think placing the lines on the other side is the way to go. I created bug: https://bugs.kde.org/show_bug.cgi?id=377012 |