Differential D4491 Diff 11837 applets/taskmanager/package/contents/ui/ToolTipInstance.qml

Changeset View

Standalone View

View Options

applets/taskmanager/package/contents/ui/ToolTipInstance.qml

Context not available.
93 level: 3 93​ level: 3
94 width: isWin ? textWidth : undefined 94​ width: isWin ? textWidth : undefined
95 height: undefined 95​ height: undefined
96​ maximumLineCount: 1
romanggUnsubmitted
Not Done

When we improve the current code, in best case we want to get rid of "magic numbers" (like 1.1 and 0.9 below or the 0.75 in current code).

romangg: When we improve the current code, in best case we want to get rid of "magic numbers" (like 1.1…
96 elide: Text.ElideRight 97​ elide: Text.ElideRight
97 text: appName 98​ text: appName
98 opacity: flatIndex == 0 99​ opacity: flatIndex == 0
Context not available.
104 level: 5 105​ level: 5
105 width: isWin ? textWidth : undefined 106​ width: isWin ? textWidth : undefined
106 height: undefined 107​ height: undefined
107 elide: Text.ElideRight 108​ maximumLineCount: 1
romanggUnsubmitted
Not Done

Because of this the tooltips aren't the same height when one of them has a too long window title. On the other hand @broulik noted that sometimes for him important informations were lost when the window title was shortened to only one line. So the 2 still makes sense.

Another option would be to use 1 and Text.ElideMiddle, so you are potentially presented different informations about the window title than in the taskmanager itself.

Because I was very keen on having same dimensions for every tooltip when redesigning them, I would favor the second option. But it's up to you.

romangg: Because of this the tooltips aren't the same height when one of them has a too long window…
jsalatasUnsubmitted
Not Done

Is it possible to have it always fixed to 2 lines and not just max to 2? Otherwise having either 1 or 2 line we would end up in unaligned/bad-looking tooltips (see screenshot), although I guess I can live with this :)

jsalatas: Is it possible to have it always fixed to 2 lines and not just max to 2? Otherwise having…
anthonyfieroniAuthorUnsubmitted
Not Done

ElideMiddle looks strange to me for title, on other hand if tiltle contains path it can be useful. Verify new patch, looks more reliable to me.

PS: jsalatas, you can use docker images https://hub.docker.com/r/kdeneon/plasma/ vs vm :)

anthonyfieroni: ElideMiddle looks strange to me for title, on other hand if tiltle contains path it can be…
109​ elide: text.search("\/.*\/.*") > -1 ? Text.ElideMiddle : Text.ElideRight
108 text: generateTitle() 110​ text: generateTitle()
109 textFormat: Text.PlainText 111​ textFormat: Text.PlainText
110 opacity: 0.75 112​ opacity: 0.75
Context not available.
114 level: 6 116​ level: 6
115 width: isWin ? textWidth : undefined 117​ width: isWin ? textWidth : undefined
116 height: undefined 118​ height: undefined
119​ maximumLineCount: 1
117 elide: Text.ElideRight 120​ elide: Text.ElideRight
118 text: isWin ? generateSubText() : "" 121​ text: isWin ? generateSubText() : ""
119 textFormat: Text.PlainText 122​ textFormat: Text.PlainText
Context not available.