Differential D4593 Diff 11319 debuggers/common/midebugger.h

Changeset View

Standalone View

View Options

debuggers/common/midebugger.h

Show First 20 Lines • Show All 129 Lines • ▼ Show 20 Line(s)128protected Q_SLOTS:
130 void readyReadStandardError(); 130​ void readyReadStandardError();
131 void processFinished(int exitCode, QProcess::ExitStatus exitStatus); 131​ void processFinished(int exitCode, QProcess::ExitStatus exitStatus);
132 void processErrored(QProcess::ProcessError); 132​ void processErrored(QProcess::ProcessError);
133 133​
134protected: 134​protected:
135 void processLine(const QByteArray& line); 135​ void processLine(const QByteArray& line);
136 136​
137protected: 137​protected:
138 QString debuggerBinary_; 138​ QString debuggerExecutable_;
flherneUnsubmitted
Done

Perhaps this should be debuggerExecutable_ for consistency within the class?

flherne: Perhaps this should be debuggerExecutable_ for consistency within the class?
kossebauAuthorUnsubmitted
Not Done

Good question. So far I was assuming that while touching lines the content would get transformed to latest coding style, even if then being inconsistent with the older neighbourhood. Will also poke devs on irc to get a +1/-1 on this.

kossebau: Good question. So far I was assuming that while touching lines the content would get…
139 KProcess* process_; 139​ KProcess* process_;
140 140​
141 MI::MICommand* currentCmd_; 141​ MI::MICommand* currentCmd_;
142 142​
143 MI::MIParser mi_parser_; 143​ MI::MIParser mi_parser_;
144 144​
145 /** The unprocessed output from debugger. Output is 145​ /** The unprocessed output from debugger. Output is
146 processed as soon as we see newline. */ 146​ processed as soon as we see newline. */
147 QByteArray buffer_; 147​ QByteArray buffer_;
148}; 148​};
149 149​
150} 150​}
151 151​
152#endif 152​#endif