Differential D3707 Diff 9332 runners/services/autotests/servicerunnertest.cpp

Changeset View

Standalone View

View Options

runners/services/autotests/servicerunnertest.cpp

  • This file was added.
1​/*
2​ * Copyright (C) 2016 Harald Sitter <sitter@kde.org>
3​ *
4​ * This library is free software; you can redistribute it and/or
5​ * modify it under the terms of the GNU Lesser General Public
6​ * License as published by the Free Software Foundation; either
dfaureUnsubmitted
Not Done

Is LGPL-v2-only on purpose here?

dfaure: Is LGPL-v2-only on purpose here?
sitterAuthorUnsubmitted
Not Done

Not particularly. It's the same as the existing source file though, to have the same license restrictions apply to both. Is it worth changing it to gpgl2+kdev considering that?

sitter: Not particularly. It's the same as the existing source file though, to have the same license…
7​ * version 2.1 of the License, or (at your option) version 3, or any
8​ * later version accepted by the membership of KDE e.V. (or its
9​ * successor approved by the membership of KDE e.V.), which shall
10​ * act as a proxy defined in Section 6 of version 3 of the license.
11​ *
12​ * This library is distributed in the hope that it will be useful,
13​ * but WITHOUT ANY WARRANTY; without even the implied warranty of
14​ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
15​ * Lesser General Public License for more details.
16​ *
17​ * You should have received a copy of the GNU Lesser General Public
18​ * License along with this library. If not, see <http://www.gnu.org/licenses/>.
19​ */
20​
21​#include <QDebug>
22​#include <QDir>
23​#include <QFile>
24​#include <QObject>
25​#include <QStandardPaths>
26​#include <QTest>
27​
28​#include <KSycoca>
29​
30​#include "../servicerunner.h"
31​
32​class ServiceRunnerTest : public QObject
33​{
34​ Q_OBJECT
35​private Q_SLOTS:
36​ void initTestCase();
37​ void cleanupTestCase();
38​
39​ void testChromeAppsRelevance();
dfaureUnsubmitted
Done

Why futile? What is futile is the fear of breaking the user's cache ;)

You don't need any of this.

Since my big ksycoca refactoring a year ago, ksycoca's filename includes a SHA1 of the data dirs (see KSycoca::absoluteFilePath(), see also the filenames in your ~/.cache).
So QStandardPaths::setTestModeEnabled(true); is already enough, given that it changes the local data home dir, so it changes the sha1.

See also e.g. kservice/autotests/kservicetest.cpp which doesn't change any env vars.

As a benefit it's also more portable to non-xdg platforms.

dfaure: Why futile? What is futile is the fear of breaking the user's cache ;) You don't need any of…
sitterAuthorUnsubmitted
Not Done

Awesome. Thanks!

sitter: Awesome. Thanks!
40​ void testKonsoleVsYakuakeComment();
41​};
42​
43​void ServiceRunnerTest::initTestCase()
44​{
45​ QStandardPaths::setTestModeEnabled(true);
46​
47​ auto appsPath = QStandardPaths::writableLocation(QStandardPaths::ApplicationsLocation);
48​ QDir(appsPath).removeRecursively();
49​ QVERIFY(QDir().mkpath(appsPath));
50​ auto fixtureDir = QDir(QFINDTESTDATA("fixtures"));
dfaureUnsubmitted
Not Done

Use QVERIFY rather than Q_ASSERT in unittests.

(better integrated with the framework, and works even in a release build)

(replace all Q_ASSERTs in this file, there are others)

dfaure: Use QVERIFY rather than Q_ASSERT in unittests. (better integrated with the framework, and…
51​ for(auto fileInfo : fixtureDir.entryInfoList(QDir::Files)) {
52​ auto source = fileInfo.absoluteFilePath();
53​ auto target = appsPath + QDir::separator() + fileInfo.fileName();
54​ QVERIFY2(QFile::copy(fileInfo.absoluteFilePath(), target),
55​ qPrintable(QString("can't copy %1 => %2").arg(source, target)));
dfaureUnsubmitted
Not Done

QVERIFY2

dfaure: QVERIFY2
56​ }
57​
58​ setlocale(LC_ALL, "C.utf8");
59​
60​ KSycoca::self()->ensureCacheValid();
dfaureUnsubmitted
Not Done

BTW if this is necessary then there's a bug in ksycoca :-)

You can leave it (it helps getting the debug output from ksycoca in the right method) but if it fails without this line, then please tell me.

dfaure: BTW if this is necessary then there's a bug in ksycoca :-) You can leave it (it helps getting…
sitterAuthorUnsubmitted
Not Done

It's only there for debug output and explicitness. Nothing to worry about ^^

sitter: It's only there for debug output and explicitness. Nothing to worry about ^^
61​}
62​
63​void ServiceRunnerTest::cleanupTestCase()
64​{
65​}
66​
67​void ServiceRunnerTest::testChromeAppsRelevance()
68​{
69​ ServiceRunner runner(this, QVariantList());
70​ Plasma::RunnerContext context;
71​ context.setQuery("chrome");
72​
73​ runner.match(context);
74​
75​ bool chromeFound = false;
76​ bool signalFound = false;
77​ for (auto match : context.matches()) {
78​ qDebug() << "matched" << match.text();
79​ if (!match.text().contains("ServiceRunnerTest")) {
80​ continue;
81​ }
82​
83​ if (match.text() == "Google Chrome ServiceRunnerTest") {
84​ QCOMPARE(match.relevance(), 0.8);
85​ chromeFound = true;
86​ } else if (match.text() == "Signal ServiceRunnerTest") {
87​ // Rates lower because it doesn't have it in the name.
88​ QCOMPARE(match.relevance(), 0.7);
89​ signalFound = true;
90​ }
91​ }
92​ QVERIFY(chromeFound);
93​ QVERIFY(signalFound);
94​}
95​
96​void ServiceRunnerTest::testKonsoleVsYakuakeComment()
97​{
98​ // Yakuake has konsole mentioned in comment, should be rated lower.
99​ ServiceRunner runner(this, QVariantList());
100​ Plasma::RunnerContext context;
101​ context.setQuery("kons");
102​
103​ runner.match(context);
104​
105​ bool konsoleFound = false;
106​ bool yakuakeFound = false;
107​ for (auto match : context.matches()) {
108​ qDebug() << "matched" << match.text();
109​ if (!match.text().contains("ServiceRunnerTest")) {
110​ continue;
111​ }
112​
113​ if (match.text() == "Konsole ServiceRunnerTest") {
114​ QCOMPARE(match.relevance(), 0.99);
115​ konsoleFound = true;
116​ } else if (match.text() == "Yakuake ServiceRunnerTest") {
117​ // Rates lower because it doesn't have it in the name.
118​ QCOMPARE(match.relevance(), 0.59);
119​ yakuakeFound = true;
120​ }
121​ }
122​ QVERIFY(konsoleFound);
123​ QVERIFY(yakuakeFound);
124​}
125​
126​QTEST_MAIN(ServiceRunnerTest)
127​
128​#include "servicerunnertest.moc"