- make sure that chrome apps have lower relevance than chrome itself
- makes sure that konsole has higher relevance than yakuake (latter only references onsole in the comment entry)
Details
Details
- it passes and at a glance doesn't seem to break my production sycoca
Would be cool if @dfaure could take a look at the ksycoca setup to make sure the test doesn't negatively impact the production cache.
Diff Detail
Diff Detail
- Repository
- R120 Plasma Workspace
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| runners/services/autotests/servicerunnertest.cpp | ||
|---|---|---|
| 6 | Is LGPL-v2-only on purpose here? | |
| 39 | Why futile? What is futile is the fear of breaking the user's cache ;) You don't need any of this. Since my big ksycoca refactoring a year ago, ksycoca's filename includes a SHA1 of the data dirs (see KSycoca::absoluteFilePath(), see also the filenames in your ~/.cache). See also e.g. kservice/autotests/kservicetest.cpp which doesn't change any env vars. As a benefit it's also more portable to non-xdg platforms. | |
Comment Actions
drop excessive code to isolate ksyscoca. setting qstandardpaths into testing mode is enough to isolate this
| runners/services/autotests/servicerunnertest.cpp | ||
|---|---|---|
| 6 | Not particularly. It's the same as the existing source file though, to have the same license restrictions apply to both. Is it worth changing it to gpgl2+kdev considering that? | |
| 39 | Awesome. Thanks! | |
Comment Actions
I would say yes, it's worth using LGPL v2+ or v2+v3 or v2+v3+e.V., whichever you prefer, for any new code. Otherwise it's even more work the day we want to relicense away from v2 only (I know because I've been trying to do that for some code for a very long time, and there are some contributors I can't reach anymore...)
| runners/services/autotests/servicerunnertest.cpp | ||
|---|---|---|
| 60 | BTW if this is necessary then there's a bug in ksycoca :-) You can leave it (it helps getting the debug output from ksycoca in the right method) but if it fails without this line, then please tell me. | |
Comment Actions
switch to lgpl-2-3-ev as suggested in review
| runners/services/autotests/servicerunnertest.cpp | ||
|---|---|---|
| 60 | It's only there for debug output and explicitness. Nothing to worry about ^^ | |