Differential D3597 Diff 8782 vcs/vcspluginhelper.cpp

Changeset View

Standalone View

View Options

vcs/vcspluginhelper.cpp

Show First 20 Lines • Show All 417 Lines • ▼ Show 20 Line(s)416 if (rev.revisionType() == VcsRevision::Invalid) {
418 return; 418​ return;
419 } 419​ }
420 420​
421 d->diffForRevAction->setData(QVariant::fromValue(rev)); 421​ d->diffForRevAction->setData(QVariant::fromValue(rev));
422 d->diffForRevGlobalAction->setData(QVariant::fromValue(rev)); 422​ d->diffForRevGlobalAction->setData(QVariant::fromValue(rev));
423 menu->addSeparator(); 423​ menu->addSeparator();
424 menu->addAction(d->diffForRevAction); 424​ menu->addAction(d->diffForRevAction);
425 menu->addAction(d->diffForRevGlobalAction); 425​ menu->addAction(d->diffForRevGlobalAction);
426 QAction* action = nullptr; 426​
427 action = menu->addAction(QIcon::fromTheme(QStringLiteral("edit-copy")), i18n("Copy Revision")); 427​ QAction* copyAction = menu->addAction(QIcon::fromTheme(QStringLiteral("edit-copy")), i18n("Copy Revision"));
ematirovUnsubmitted
Done

Not really necessary probably. @kfunk, same question?

ematirov: Not really necessary probably. @kfunk, same question?
kfunkUnsubmitted
Done

Change looks good to me. I'd keep it.

kfunk: Change looks good to me. I'd keep it.
428 connect(action, &QAction::triggered, this, [this, rev]() { 428​ connect(copyAction, &QAction::triggered, this, [this, rev]() {
429 QApplication::clipboard()->setText(rev.revisionValue().toString()); 429​ QApplication::clipboard()->setText(rev.revisionValue().toString());
430 }); 430​ });
431 action = menu->addAction(QIcon::fromTheme(QStringLiteral("view-history")), i18n("History...")); 431​
432 connect(action, &QAction::triggered, this, [this, rev]() { 432​ QAction* historyAction = menu->addAction(QIcon::fromTheme(QStringLiteral("view-history")), i18n("History..."));
433​ connect(historyAction, &QAction::triggered, this, [this, rev]() {
433 history(rev); 434​ history(rev);
434 }); 435​ });
435} 436​}
436 437​
437void VcsPluginHelper::update() 438​void VcsPluginHelper::update()
438{ 439​{
439 EXECUTE_VCS_METHOD(update); 440​ EXECUTE_VCS_METHOD(update);
440} 441​}
▲ Show 20 Lines • Show All 44 Lines • Show Last 20 Lines