Differential D3580 Diff 8725 language/classmodel/documentclassesfolder.cpp

Changeset View

Standalone View

View Options

language/classmodel/documentclassesfolder.cpp

Context not available.
230 const CodeModelItem& item = codeModelItems[codeModelItemIndex]; 230​ const CodeModelItem& item = codeModelItems[codeModelItemIndex];
231 231​
232 // Don't insert unknown or forward declarations into the class browser 232​ // Don't insert unknown or forward declarations into the class browser
233 if ( (item.kind & CodeModelItem::Unknown) || (item.kind & CodeModelItem::ForwardDeclaration) ) 233​ if ( item.kind == CodeModelItem::Unknown || (item.kind & CodeModelItem::ForwardDeclaration) )
ematirovUnsubmitted
Not Done

Testing for CodeModelItem::Unknown makes no sense there since it's constant (0).
The problem of original check is that (item.kind & 0) == 0 with any value of item.kind, so it doesn't check anything.

Probably solutions are:

  1. check if item.kind is equal to CodeModelItem::Unknown instead of using bitwise operation there;
  2. change value of CodeModelItem::Unknown to some power of 2 which is not used yet in CodeModelItem::Kind values.

Probably first one will go but I'll prefer to hear @kfunk's opinion on that

ematirov: Testing for CodeModelItem::Unknown makes no sense there since it's constant (0). The problem of…
234 continue; 234​ continue;
235 235​
236 KDevelop::QualifiedIdentifier id = item.id.identifier(); 236​ KDevelop::QualifiedIdentifier id = item.id.identifier();
Context not available.