Changeset View
Changeset View
Standalone View
Standalone View
firsttimewizard.h
Show First 20 Lines • Show All 58 Lines • ▼ Show 20 Line(s) | 47 | public: | |||
---|---|---|---|---|---|
59 | bool m_downloadRunning; | 59 | bool m_downloadRunning; | ||
60 | bool m_downloadFinished; | 60 | bool m_downloadFinished; | ||
61 | bool m_installFinished; | 61 | bool m_installFinished; | ||
62 | 62 | | |||
63 | //get mcu list from avrdude | 63 | //get mcu list from avrdude | ||
64 | QProcess *m_avrdudeProcess; | 64 | QProcess *m_avrdudeProcess; | ||
65 | KFormat *m_format; | 65 | KFormat *m_format; | ||
66 | 66 | | |||
67 | QString getArduinoPath(); | 67 | /** | ||
68 | QString getSketchbookPath(); | 68 | * @brief Populate `Arduino Path` field with valid path to a Arduino install. | ||
69 | * | ||||
70 | * If a setting exists, it is used, otherwise standard paths are verified | ||||
71 | * and if a valid one is found, it is used. | ||||
72 | */ | ||||
73 | void fetchArduinoPath(); | ||||
74 | /** | ||||
75 | * @brief Populate `Sketchbook Path` field with valid projects path. | ||||
76 | * | ||||
77 | * If a setting exists, it is used, otherwise standard paths are verified | ||||
78 | * and if a valid one is found, it is used. | ||||
79 | */ | ||||
80 | void fetchSketchbookPath(); | ||||
kfunk: Bad function naming. `getFoo` indicates a getter.
Rather call it `fetchFoo`? Documenting the… | |||||
69 | QString downloadAndInstallArduino(); | 81 | QString downloadAndInstallArduino(); | ||
70 | bool validateCurrentPage(); | 82 | bool validateCurrentPage(); | ||
71 | int nextId() const; | 83 | int nextId() const; | ||
72 | bool finish(); | 84 | bool finish(); | ||
73 | 85 | | |||
74 | void onDownloadProgress(qint64 received, qint64 total); | 86 | void onDownloadProgress(qint64 received, qint64 total); | ||
75 | void chooseArduinoPath(); | 87 | void chooseArduinoPath(); | ||
76 | void validateCurrentId(int id); | 88 | void validateCurrentId(int id); | ||
Show All 9 Lines |
Bad function naming. getFoo indicates a getter.
Rather call it fetchFoo? Documenting the functions is even better.