Fetch KConfig settings if they exist.
ClosedPublic
Actions

Authored by obogdan on Dec 2 2016, 9:59 AM.

Details

Reviewers

patrickelectric
kfunk

Commits

R185:8d46084c20f3: Fetch KConfig settings if they exist.

Summary

The settings were set, but never retrieved, thus misleading the user.

Test Plan

Recompiled and installed, started the Arduino settings from Embedded -> Arduino, and the saved settings were loaded.

Diff Detail

Repository

R185 KDevelop Plugin: Embedded Platforms

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

obogdan updated this revision to Diff 8691.Dec 2 2016, 9:59 AM

obogdan retitled this revision from to Fetch KConfig settings if they exist..

obogdan updated this object.

obogdan edited the test plan for this revision. (Show Details)

Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptDec 2 2016, 9:59 AM

kfunk requested changes to this revision.Dec 2 2016, 10:02 AM

kfunk added a reviewer: kfunk.

kfunk added a subscriber: kfunk.

kfunk added inline comments.

firsttimewizard.cpp
365–366	Not needed
firsttimewizard.h
67–80	Bad function naming. `getFoo` indicates a getter. Rather call it `fetchFoo`? Documenting the functions is even better.

This revision now requires changes to proceed.Dec 2 2016, 10:02 AM

Renamed functions. Documented functions.

obogdan marked 2 inline comments as done.Dec 2 2016, 10:10 AM

obogdan added a reviewer: patrickelectric.

obogdan added a project: KDevelop.

obogdan added a subscriber: patrickelectric.

Okay, much better :)

I'll leave the real review to Patrick

patrickelectric accepted this revision.Dec 2 2016, 10:17 AM

patrickelectric edited edge metadata.

Closed by commit R185:8d46084c20f3: Fetch KConfig settings if they exist. (authored by obogdan). · Explain WhyDec 2 2016, 10:20 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			firsttimewizard.h (16 lines)
M			firsttimewizard.cpp (26 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	8691	0c6eb4e		Dec 2 2016, 9:59 AM	★	★
Diff 2	8692	0c6eb4e	- Renamed functions. Documented functions.	Dec 2 2016, 10:10 AM	★	★
Diff 3	8693	0c6eb4e	R185:8d46084c20f3f7d56816dd4b1fa43c7851702ee1	Dec 2 2016, 10:19 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
f94f26894fb6	724230aec73b	423de7c05512	Ovidiu-Florin BOGDAN	Renamed functions. Documented functions.	Dec 2 2016, 10:10 AM
423de7c05512	e1f7bb2f8788	0c6eb4e01426	Ovidiu-Florin BOGDAN	Fetch KConfig settings if they exist. (Show More…)	Dec 2 2016, 9:41 AM

Fetch KConfig settings if they exist.ClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 8693

firsttimewizard.h

firsttimewizard.cpp

Fetch KConfig settings if they exist.
ClosedPublic
Actions

Revision Contents
Changeset List