Fetch KConfig settings if they exist.

Authored by obogdan on Dec 2 2016, 9:59 AM.



The settings were set, but never retrieved, thus misleading the user.

Test Plan

Recompiled and installed, started the Arduino settings from Embedded -> Arduino, and the saved settings were loaded.

Diff Detail

R185 KDevelop Plugin: Embedded Platforms
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
obogdan updated this revision to Diff 8691.Dec 2 2016, 9:59 AM
obogdan retitled this revision from to Fetch KConfig settings if they exist..
obogdan updated this object.
obogdan edited the test plan for this revision. (Show Details)
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptDec 2 2016, 9:59 AM
kfunk requested changes to this revision.Dec 2 2016, 10:02 AM
kfunk added a reviewer: kfunk.
kfunk added a subscriber: kfunk.
kfunk added inline comments.

Not needed


Bad function naming. getFoo indicates a getter.

Rather call it fetchFoo? Documenting the functions is even better.

This revision now requires changes to proceed.Dec 2 2016, 10:02 AM
obogdan updated this revision to Diff 8692.Dec 2 2016, 10:10 AM
obogdan edited edge metadata.
  • Renamed functions. Documented functions.
obogdan marked 2 inline comments as done.Dec 2 2016, 10:10 AM
obogdan added a reviewer: patrickelectric.
obogdan added a project: KDevelop.
obogdan added a subscriber: patrickelectric.
kfunk added a comment.Dec 2 2016, 10:14 AM

Okay, much better :)

I'll leave the real review to Patrick

patrickelectric accepted this revision.Dec 2 2016, 10:17 AM
patrickelectric edited edge metadata.
This revision was automatically updated to reflect the committed changes.