Differential D29786 Diff 82972 scripting/workspace_wrapper.h

Changeset View

Standalone View

View Options

scripting/workspace_wrapper.h

Context not available.
255 * Returns the name for the given @p desktop. 255​ * Returns the name for the given @p desktop.
256 */ 256​ */
257 Q_SCRIPTABLE QString desktopName(int desktop) const; 257​ Q_SCRIPTABLE QString desktopName(int desktop) const;
258​ /**
259​ * Create a new virtual desktop at the requested position.
260​ * @param position The position of the desktop. It should be in range [1, count + 1].
zzagUnsubmitted
Done

why not in range [0, count]?

zzag: why not in range [0, count]?
tcorreabrAuthorUnsubmitted
Done

I don't know why but the client.desktop property is not zero based, at least on X11. So in a situation with 2 desktops, the new desktop can be inserted at position 1, 2 or 3.

tcorreabr: I don't know why but the client.desktop property is not zero based, at least on X11. So in a…
zzagUnsubmitted
Done

I don't know why but the client.desktop property is not zero based

It's not zero-based because of the goddamn X11...

So in a situation with 2 desktops, the new desktop can be inserted at position 1, 2 or 3.

In order to match what input values VirtualDesktopManager::createVirtualDesktop() expects, I think it's better to keep the position in range [0, count]. We could make client.desktop zero-based in plasma 6.

It's also worth to point out that the client.desktop property is deprecated since a window can be on more than just one virtual desktop.

zzag: > I don't know why but the client.desktop property is not zero based It's not zero-based…
261​ * @param name The name for the new desktop, if empty the default name will be used.
262​ */
263​ Q_SCRIPTABLE void createDesktop(int position, const QString &name) const;
264​ /**
265​ * Remove the virtual desktop at the requested position
266​ * @param position The position of the desktop to be removed. It should be in range [1, count].
267​ */
268​ Q_SCRIPTABLE void removeDesktop(int position) const;
258 /** 269​ /**
259 * Provides support information about the currently running KWin instance. 270​ * Provides support information about the currently running KWin instance.
260 */ 271​ */
Context not available.