There are methods to create and remove virtual desktops via dbus, but I think it would be convenient to provide these methods for KWin scripts as well.
Details
Details
Diff Detail
Diff Detail
- Repository
- R108 KWin
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| scripting/workspace_wrapper.h | ||
|---|---|---|
| 260 | why not in range [0, count]? | |
| scripting/workspace_wrapper.cpp | ||
|---|---|---|
| 282–283 | coding style nit: whitespace before * and put the return statement on a new line. | |
| scripting/workspace_wrapper.h | ||
|---|---|---|
| 260 |
It's not zero-based because of the goddamn X11...
In order to match what input values VirtualDesktopManager::createVirtualDesktop() expects, I think it's better to keep the position in range [0, count]. We could make client.desktop zero-based in plasma 6. It's also worth to point out that the client.desktop property is deprecated since a window can be on more than just one virtual desktop. | |