Differential D29487 Diff 82913 desktop/org.kde.spectacle.desktop.cmake

Changeset View

Standalone View

View Options

desktop/org.kde.spectacle.desktop.cmake

Show First 20 Lines • Show All 134 Lines • ▼ Show 20 Line(s)
135Keywords[ru]=snapshot;capture;print;screenshot;snipping;snip;снимок;захват;печать;снимок экрана;скриншот; 135​Keywords[ru]=snapshot;capture;print;screenshot;snipping;snip;снимок;захват;печать;снимок экрана;скриншот;
136Keywords[sk]=snímka;zachytiť;tlač;snímka obrazovky;strihanie;strihať 136​Keywords[sk]=snímka;zachytiť;tlač;snímka obrazovky;strihanie;strihať
137Keywords[sl]=snapshot;capture;print;screenshot;snipping;snip; 137​Keywords[sl]=snapshot;capture;print;screenshot;snipping;snip;
138Keywords[sv]=ta;skriva ut;skärmbild;klippa ut;klippa; 138​Keywords[sv]=ta;skriva ut;skärmbild;klippa ut;klippa;
139Keywords[uk]=знімок;захоплення;друк;знімок вікна;вікно;знімок екрана;екран;snapshot;capture;print;screenshot;snipping;snip; 139​Keywords[uk]=знімок;захоплення;друк;знімок вікна;вікно;знімок екрана;екран;snapshot;capture;print;screenshot;snipping;snip;
140Keywords[x-test]=xxsnapshotxx;xxcapturexx;xxprintxx;xxscreenshotxx;xxsnippingxx;xxsnipxx; 140​Keywords[x-test]=xxsnapshotxx;xxcapturexx;xxprintxx;xxscreenshotxx;xxsnippingxx;xxsnipxx;
141Keywords[zh_CN]=snapshot;capture;print;screenshot;snipping;snip;快照;截图;抓取;屏幕截图;截屏;抓屏;截取; 141​Keywords[zh_CN]=snapshot;capture;print;screenshot;snipping;snip;快照;截图;抓取;屏幕截图;截屏;抓屏;截取;
142Keywords[zh_TW]=snapshot;capture;print;screenshot;snipping;snip;截圖;擷取;截圖程式 142​Keywords[zh_TW]=snapshot;capture;print;screenshot;snipping;snip;截圖;擷取;截圖程式
143Exec=@QtBinariesDir@/qdbus org.kde.Spectacle / StartAgent 143​Exec=${CMAKE_INSTALL_PREFIX}/bin/spectacle
davidreUnsubmitted
Done

Is there a reason that we hardcode the path instead of "spectacle"?

davidre: Is there a reason that we hardcode the path instead of "spectacle"?
mevenAuthorUnsubmitted
Not Done

KWin with D29407 will find executable path taking screenshot using their Exec field in their desktop file.
And since screenshot is considered sensitive information in Wayland, we are expecting absolute path in Exec field to make sure the files match.
This then allow KWin to authorize or not the file to take screenshots if it has a special key in its desktop file.
This bit will be added to spectacle in D29408 after this refactoring is done.

You'd get Error calling KWin DBus interface: "org.kde.kwin.Screenshot.Error.NoAuthorized" "The process is not authorized to take a screenshot"

meven: KWin with D29407 will find executable path taking screenshot using their Exec field in their…
144Icon=spectacle 144​Icon=spectacle
145Type=Application 145​Type=Application
146Terminal=false 146​Terminal=false
147StartupNotify=false 147​StartupNotify=false
148Actions=FullScreenScreenShot;CurrentMonitorScreenShot;ActiveWindowScreenShot;RectangularRegionScreenShot; 148​Actions=FullScreenScreenShot;CurrentMonitorScreenShot;ActiveWindowScreenShot;RectangularRegionScreenShot;
149X-DBUS-StartupType=Multi 149​X-DBUS-StartupType=Unique
150X-DBUS-ServiceName=org.kde.Spectacle 150​X-DBUS-ServiceName=org.kde.Spectacle
151X-KDE-Shortcuts=Print 151​X-KDE-Shortcuts=Print
152 152​
153[Desktop Action FullScreenScreenShot] 153​[Desktop Action FullScreenScreenShot]
154Name=Capture Entire Desktop 154​Name=Capture Entire Desktop
155Name[ar]=التقط سطح المكتب بالكامل 155​Name[ar]=التقط سطح المكتب بالكامل
156Name[ca]=Captura l'escriptori sencer 156​Name[ca]=Captura l'escriptori sencer
157Name[ca@valencia]=Captura l'escriptori sencer 157​Name[ca@valencia]=Captura l'escriptori sencer
▲ Show 20 Lines • Show All 166 Lines • Show Last 20 Lines