Differential D29708 Diff 82806 autotests/kfilewidgettest.cpp

Changeset View

Standalone View

View Options

autotests/kfilewidgettest.cpp

Show First 20 Lines • Show All 212 Lines • ▼ Show 20 Line(s)202 {
213 QTest::newRow("path") << baseDir << baseDir + QLatin1Char('/') + fileName << baseDir << fileName; 213​ QTest::newRow("path") << baseDir << baseDir + QLatin1Char('/') + fileName << baseDir << fileName;
214 QTest::newRow("differentPath") << QDir::rootPath() << baseDir + QLatin1Char('/') + fileName << baseDir << fileName; 214​ QTest::newRow("differentPath") << QDir::rootPath() << baseDir + QLatin1Char('/') + fileName << baseDir << fileName;
215 // kdeplatformfiledialoghelper.cpp calls setSelection(URL as string) 215​ // kdeplatformfiledialoghelper.cpp calls setSelection(URL as string)
216 QTest::newRow("url") << baseDir << QUrl::fromLocalFile(baseDir + QLatin1Char('/') + fileName).toString() << baseDir << fileName; 216​ QTest::newRow("url") << baseDir << QUrl::fromLocalFile(baseDir + QLatin1Char('/') + fileName).toString() << baseDir << fileName;
217 // What if someone calls setSelection(fileName)? That breaks, hence e70f8134a2b in plasma-integration.git 217​ // What if someone calls setSelection(fileName)? That breaks, hence e70f8134a2b in plasma-integration.git
218 QTest::newRow("filename") << baseDir << fileName << baseDir << fileName; 218​ QTest::newRow("filename") << baseDir << fileName << baseDir << fileName;
219 } 219​ }
220 220​
221​#if KIOFILEWIDGETS_BUILD_DEPRECATED_SINCE(5, 33)
221 void testSetSelection() 222​ void testSetSelection()
222 { 223​ {
223 // GIVEN 224​ // GIVEN
224 QFETCH(QString, baseDir); 225​ QFETCH(QString, baseDir);
225 QFETCH(QString, selection); 226​ QFETCH(QString, selection);
226 QFETCH(QString, expectedBaseDir); 227​ QFETCH(QString, expectedBaseDir);
227 QFETCH(QString, expectedCurrentText); 228​ QFETCH(QString, expectedCurrentText);
228 const QUrl baseUrl = QUrl::fromLocalFile(baseDir).adjusted(QUrl::StripTrailingSlash); 229​ const QUrl baseUrl = QUrl::fromLocalFile(baseDir).adjusted(QUrl::StripTrailingSlash);
Show All 9 Lines
238 239​
239 // THEN 240​ // THEN
240 QCOMPARE(fw.baseUrl().adjusted(QUrl::StripTrailingSlash), expectedBaseUrl); 241​ QCOMPARE(fw.baseUrl().adjusted(QUrl::StripTrailingSlash), expectedBaseUrl);
241 //if (QByteArray(QTest::currentDataTag()) == "filename") { 242​ //if (QByteArray(QTest::currentDataTag()) == "filename") {
242 QEXPECT_FAIL("filename", "setSelection cannot work with filenames, bad API", Continue); 243​ QEXPECT_FAIL("filename", "setSelection cannot work with filenames, bad API", Continue);
243 //} 244​ //}
244 QCOMPARE(fw.locationEdit()->currentText(), expectedCurrentText); 245​ QCOMPARE(fw.locationEdit()->currentText(), expectedCurrentText);
245 } 246​ }
247​#endif
246 248​
247 void testSetSelectedUrl_data() 249​ void testSetSelectedUrl_data()
248 { 250​ {
249 QTest::addColumn<QString>("baseDir"); 251​ QTest::addColumn<QString>("baseDir");
250 QTest::addColumn<QUrl>("selectionUrl"); 252​ QTest::addColumn<QUrl>("selectionUrl");
251 QTest::addColumn<QString>("expectedBaseDir"); 253​ QTest::addColumn<QString>("expectedBaseDir");
252 QTest::addColumn<QString>("expectedCurrentText"); 254​ QTest::addColumn<QString>("expectedCurrentText");
253 255​
▲ Show 20 Lines • Show All 284 Lines • Show Last 20 Lines