Differential D28402 Diff 80429 src/settings/general/previewssettingspage.h

Changeset View

Standalone View

src/settings/general/previewssettingspage.h

Show All 14 Lines
15	* along with this program; if not, write to the *	15		* along with this program; if not, write to the *
16	* Free Software Foundation, Inc., *	16		* Free Software Foundation, Inc., *
17	* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA *	17		* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA *
18	***************************************************************************/	18		***************************************************************************/
19		19
20	#ifndef PREVIEWSSETTINGSPAGE_H	20		#ifndef PREVIEWSSETTINGSPAGE_H
21	#define PREVIEWSSETTINGSPAGE_H	21		#define PREVIEWSSETTINGSPAGE_H
22		22
		23		#include <QtWidgets/QCheckBox>
			ngrahamUnsubmitted Done Just forward-declare this, as with the below `class [thing]` lines. Also, no need to include the `QtWidgets/` prefix. ngraham: Just forward-declare this, as with the below `class [thing]` lines. Also, no need to include…
23	#include "settings/settingspagebase.h"	24		#include "settings/settingspagebase.h"
24		25
25	class QSpinBox;	26		class QSpinBox;
26	class QListView;	27		class QListView;
27	class QModelIndex;	28		class QModelIndex;
28		29
29	/**	30		/**
30	* @brief Allows the configuration of file previews.	31		* @brief Allows the configuration of file previews.
Show All 20 Lines		51	protected:
51	void showEvent(QShowEvent* event) override;	52		void showEvent(QShowEvent* event) override;
52		53
53	private slots:	54		private slots:
54	void configureService(const QModelIndex& index);	55		void configureService(const QModelIndex& index);
55		56
56	private:	57		private:
57	void loadPreviewPlugins();	58		void loadPreviewPlugins();
58	void loadSettings();	59		void loadSettings();
		60		void useTypeChanged();
			elvisangelaccioUnsubmitted Done This shuld be in the `private slots` section. While at it, please call it `toggleLocalFileSize()` or similar, since this is a slot and not a signal. elvisangelaccio: This shuld be in the `private slots` section. While at it, please call it `toggleLocalFileSize…
59		61
60	private:	62		private:
61	bool m_initialized;	63		bool m_initialized;
62	QListView *m_listView;	64		QListView *m_listView;
63	QStringList m_enabledPreviewPlugins;	65		QStringList m_enabledPreviewPlugins;
		66		QCheckBox *m_localFileSizeLimit;
		67		QSpinBox* m_localFileSizeBox;
64	QSpinBox* m_remoteFileSizeBox;	68		QSpinBox* m_remoteFileSizeBox;
65	};	69		};
66		70
67	#endif	71		#endif