Differential D27949 Diff 79869 src/services/lastfm/LastFmServiceConfig.h

Changeset View

Standalone View

src/services/lastfm/LastFmServiceConfig.h

Show All 12 Lines
13	* *	13		* *
14	* You should have received a copy of the GNU General Public License along with *	14		* You should have received a copy of the GNU General Public License along with *
15	* this program. If not, see <http://www.gnu.org/licenses/>. *	15		* this program. If not, see <http://www.gnu.org/licenses/>. *
16	****************************************************************************************/	16		****************************************************************************************/
17		17
18	#ifndef LASTFMSERVICECONFIG_H	18		#ifndef LASTFMSERVICECONFIG_H
19	#define LASTFMSERVICECONFIG_H	19		#define LASTFMSERVICECONFIG_H
20		20
21	#include "services/lastfm/amarok_lastfm_shared_export.h"	21		#include "services/lastfm/amarok_service_lastfm_config_export.h"
22		22
23	#include <QObject>	23		#include <QObject>
24	#include <QSharedPointer>	24		#include <QSharedPointer>
25	#include <QString>	25		#include <QString>
26		26
27	namespace KWallet {	27		namespace KWallet {
28	class Wallet;	28		class Wallet;
29	}	29		}
30	class QMessageBox;	30		class QMessageBox;
31	class LastFmServiceConfig;	31		class LastFmServiceConfig;
32	typedef QSharedPointer<LastFmServiceConfig> LastFmServiceConfigPtr;	32		typedef QSharedPointer<LastFmServiceConfig> LastFmServiceConfigPtr;
33		33
34	/**	34		/**
35	* Configuration of the Last.fm plugin. Because some operations are async, you should	35		* Configuration of the Last.fm plugin. Because some operations are async, you should
36	* connect to the updated() signal and listen to changes, especially ones to username,	36		* connect to the updated() signal and listen to changes, especially ones to username,
37	* password or sessionKey.	37		* password or sessionKey.
			heikobeckerUnsubmitted Done Any reason not to use a generated export header for that? heikobecker: Any reason not to use a generated export header for that?
			pgomesAuthorUnsubmitted Done No strong reason. The reason was that I didn't know what's the different between `QT_DECL_EXPORT` and the generated `__attribute__((visibility("default")))`. Also Ampache and Gpodder do not generate exports, so I followed them. Should I use the attribute? pgomes: No strong reason. The reason was that I didn't know what's the different between…
38	*/	38		*/
39	class AMAROK_LASTFM_SHARED_EXPORT LastFmServiceConfig : public QObject	39		class AMAROK_SERVICE_LASTFM_CONFIG_EXPORT LastFmServiceConfig : public QObject
40	{	40		{
41	Q_OBJECT	41		Q_OBJECT
42	public:	42		public:
43	static const char *configSectionName() { return "Service_LastFm"; }	43		static const char *configSectionName() { return "Service_LastFm"; }
44		44
45	/**	45		/**
46	* Singleton pattern accessor. Not thread safe - must be called from the main	46		* Singleton pattern accessor. Not thread safe - must be called from the main
47	* thread.	47		* thread.
▲ Show 20 Lines • Show All 96 Lines • Show Last 20 Lines