Changeset View
Changeset View
Standalone View
Standalone View
src/qtquick/qml/Button.qml
Show First 20 Lines • Show All 76 Lines • ▼ Show 20 Line(s) | 35 | QtControls.Button { | |||
---|---|---|---|---|---|
77 | property alias engine: ghnsDialog.engine | 77 | property alias engine: ghnsDialog.engine | ||
78 | 78 | | |||
79 | /** | 79 | /** | ||
80 | * Contains the entries which have been changed. | 80 | * Contains the entries which have been changed. | ||
81 | * @note This is cleared when the dialog is shown, so the changed entries are those | 81 | * @note This is cleared when the dialog is shown, so the changed entries are those | ||
82 | * changed since the dialog was opened most recently (rather than the lifetime | 82 | * changed since the dialog was opened most recently (rather than the lifetime | ||
83 | * of the instance of the Button component) | 83 | * of the instance of the Button component) | ||
84 | */ | 84 | */ | ||
85 | property var changedEntries | 85 | property alias changedEntries: ghnsDialog.changedEntries | ||
86 | Binding { | | |||
87 | target: component | | |||
88 | property: "changedEntries" | | |||
89 | value: ghnsDialog.engine.changedEntries | | |||
90 | } | | |||
leinir: Given the various annoying side effects of the cleaner solutions, perhaps reintroduce this, but… | |||||
91 | 86 | | |||
92 | /** | 87 | /** | ||
93 | * If this is true (default is false), the button will be shown when the Kiosk settings are such | 88 | * If this is true (default is false), the button will be shown when the Kiosk settings are such | ||
94 | * that Get Hot New Stuff is disallowed (and any other time enabled is set to false). | 89 | * that Get Hot New Stuff is disallowed (and any other time enabled is set to false). | ||
95 | * Usually you would want to leave this alone, but occasionally you may have a reason to | 90 | * Usually you would want to leave this alone, but occasionally you may have a reason to | ||
96 | * leave a button in place that the user is unable to enable. | 91 | * leave a button in place that the user is unable to enable. | ||
97 | */ | 92 | */ | ||
98 | property bool visibleWhenDisabled: false | 93 | property bool visibleWhenDisabled: false | ||
Show All 30 Lines |
Given the various annoying side effects of the cleaner solutions, perhaps reintroduce this, but add a "when" clause to ensure it only happens when we want it to? Maybe something as simple as just checking it is only forwarded when engine is, in fact, not null might work... or, perhaps, if engine is not null, and also initialised? since it really shouldn't be giving you any changed entries until after initialisation has been completed... Meaning something like
maybe perhaps could be...