Reduce superfluous changedEntriesChanged emissions
Needs ReviewPublic

Authored by broulik on Thu, Mar 26, 9:33 AM.

Details

Reviewers
leinir
ahiemstra
Group Reviewers
Frameworks
Summary

For some reason I couldn't entirely get behind, changedEntries was signalled to change on the QML side on component creation.
Even when replacing the Binding by a direct binding, this wouldn't work. However, while I can't just alias it, it turns out, ghnsDialog already has a changedEntries alias, which we can then just alias to.
Furthermore, don't signal a change when clearing if it was already empty.

This fixes the wallpaper model in Plasma reloading in-flight, causing thumbnail generation to fail. While this is a genuine bug in the model that should be fixed it only started to be a problem with GHNS needlessly reloading the model.

BUG: 419234

Test Plan
  • My thumbnails show up fine again
  • Installing a new thumbnail still reloads the model (changedEntries is signalled to change when I install something)

Diff Detail

Repository
R304 KNewStuff
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Thu, Mar 26, 9:33 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptThu, Mar 26, 9:33 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
broulik requested review of this revision.Thu, Mar 26, 9:33 AM
broulik edited the summary of this revision. (Show Details)

Hmm, when doing this, Qt suddenly refuses to pass the entries through to a QQmlListReference