Differential D28282 Diff 78522 kcms/keys/globalshortcuts.cpp

Changeset View

Standalone View

View Options

kcms/keys/globalshortcuts.cpp

Show All 31 Lines
32K_PLUGIN_FACTORY(GlobalShortcutsModuleFactory, registerPlugin<GlobalShortcutsModule>();) 32​K_PLUGIN_FACTORY(GlobalShortcutsModuleFactory, registerPlugin<GlobalShortcutsModule>();)
33 33​
34GlobalShortcutsModule::GlobalShortcutsModule(QWidget *parent, const QVariantList &args) 34​GlobalShortcutsModule::GlobalShortcutsModule(QWidget *parent, const QVariantList &args)
35 : KCModule(parent, args), 35​ : KCModule(parent, args),
36 editor(nullptr) 36​ editor(nullptr)
37{ 37​{
38 KCModule::setButtons(KCModule::Buttons(KCModule::Default | KCModule::Apply | KCModule::Help)); 38​ KCModule::setButtons(KCModule::Buttons(KCModule::Default | KCModule::Apply | KCModule::Help));
39 39​
40 ​
41 // Create the kglobaleditor 40​ // Create the kglobaleditor
42 editor = new KGlobalShortcutsEditor(this, KShortcutsEditor::GlobalAction); 41​ editor = new KGlobalShortcutsEditor(this, KShortcutsEditor::GlobalAction);
43 connect(editor, SIGNAL(changed(bool)), this, SIGNAL(changed(bool))); 42​ connect(editor, &KGlobalShortcutsEditor::changed, this, &GlobalShortcutsModule::markAsChanged);
davidedmundsonUnsubmitted
Done

Use markAsChanged then you don't need to overload.

davidedmundson: Use markAsChanged then you don't need to overload.
44 43​
45 // Layout the hole bunch 44​ // Layout the hole bunch
46 QVBoxLayout *global = new QVBoxLayout; 45​ QVBoxLayout *global = new QVBoxLayout;
47 global->addWidget(editor); 46​ global->addWidget(editor);
48 setLayout(global); 47​ setLayout(global);
49} 48​}
50 49​
51GlobalShortcutsModule::~GlobalShortcutsModule() 50​GlobalShortcutsModule::~GlobalShortcutsModule()
Show All 39 Lines