Differential D27791 Diff 78050 src/lib/preferences/pluginsmanager.cpp

Changeset View

Standalone View

View Options

src/lib/preferences/pluginsmanager.cpp

Context not available.
52 connect(ui->list, &QListWidget::currentItemChanged, this, &PluginsManager::currentChanged); 52​ connect(ui->list, &QListWidget::currentItemChanged, this, &PluginsManager::currentChanged);
53 connect(ui->list, &QListWidget::itemChanged, this, &PluginsManager::itemChanged); 53​ connect(ui->list, &QListWidget::itemChanged, this, &PluginsManager::itemChanged);
54 connect(mApp->plugins(), &Plugins::availablePluginsChanged, this, &PluginsManager::refresh); 54​ connect(mApp->plugins(), &Plugins::availablePluginsChanged, this, &PluginsManager::refresh);
55 ​
56 connect(ui->search,&QLineEdit::textChanged,this,&PluginsManager::addFilter); 55​ connect(ui->search,&QLineEdit::textChanged,this,&PluginsManager::addFilter);
SGOravaUnsubmitted
Not Done

same here, I would keep a blank line after connect commands.

SGOrava: same here, I would keep a blank line after connect commands.
57 ​
58 ui->list->setItemDelegate(new PluginListDelegate(ui->list)); 56​ ui->list->setItemDelegate(new PluginListDelegate(ui->list));
59} 57​}
60 58​
SGOravaUnsubmitted
Not Done

Please do not delete the blank line, or lines which you do not WANT to delete.

It is good to keep unrelated code intact.

SGOrava: Please do not delete the blank line, or lines which you do not WANT to delete. It is good to…
Context not available.
245void PluginsManager::addFilter(const QString& filter) { 243​void PluginsManager::addFilter(const QString& filter) {
246 for (int i = 0; i < ui->list->count();++i) { 244​ for (int i = 0; i < ui->list->count();++i) {
247 const QString& pluginName = ui->list->item(i)->text(); 245​ const QString& pluginName = ui->list->item(i)->text();
248 if (pluginName.contains(filter,Qt::CaseInsensitive) || !filter.size()) 246​ if (pluginName.startsWith(filter,Qt::CaseInsensitive) || !filter.size())
SGOravaUnsubmitted
Not Done

This checks only if the plugin name starts with given string which is insufficient for proper search.

Using QString::contains() fits the criteria of "search" much more.

Plus Always use {} for commands after the conditions.

SGOrava: This checks only if the plugin name starts with given string which is insufficient for proper…
249 ui->list->item(i)->setHidden(false); 247​ ui->list->item(i)->setHidden(false);
250 else 248​ else
251 ui->list->item(i)->setHidden(true); 249​ ui->list->item(i)->setHidden(true);
Context not available.