Differential D27949 Diff 77890 src/services/lastfm/LastFmServiceConfig.h

Changeset View

Standalone View

View Options

src/services/lastfm/LastFmServiceConfig.h

Context not available.
18#ifndef LASTFMSERVICECONFIG_H 18​#ifndef LASTFMSERVICECONFIG_H
19#define LASTFMSERVICECONFIG_H 19​#define LASTFMSERVICECONFIG_H
20 20​
21#include "services/lastfm/amarok_lastfm_shared_export.h" ​
22 ​
23#include <QObject> 21​#include <QObject>
24#include <QSharedPointer> 22​#include <QSharedPointer>
25#include <QString> 23​#include <QString>
Context not available.
31class LastFmServiceConfig; 29​class LastFmServiceConfig;
32typedef QSharedPointer<LastFmServiceConfig> LastFmServiceConfigPtr; 30​typedef QSharedPointer<LastFmServiceConfig> LastFmServiceConfigPtr;
33 31​
32​#ifdef AMAROK_LASTFM_SHARED_EXPORT
33​ #define AMAROK_LASTFM_SHARED_EXPORT Q_DECL_EXPORT
34​#else
35​ #define AMAROK_LASTFM_SHARED_EXPORT Q_DECL_IMPORT
36​#endif
37​
heikobeckerUnsubmitted
Done

Any reason not to use a generated export header for that?

heikobecker: Any reason not to use a generated export header for that?
pgomesAuthorUnsubmitted
Done

No strong reason.

The reason was that I didn't know what's the different between QT_DECL_EXPORT and the generated __attribute__((visibility("default"))).
Also Ampache and Gpodder do not generate exports, so I followed them. Should I use the attribute?

pgomes: No strong reason. The reason was that I didn't know what's the different between…
34/** 38​/**
35 * Configuration of the Last.fm plugin. Because some operations are async, you should 39​ * Configuration of the Last.fm plugin. Because some operations are async, you should
36 * connect to the updated() signal and listen to changes, especially ones to username, 40​ * connect to the updated() signal and listen to changes, especially ones to username,
Context not available.