Differential D27122 Diff 75145 src/desktoptheme/breeze/metadata.desktop.cmake

Changeset View

Standalone View

View Options

src/desktoptheme/breeze/metadata.desktop.cmake

Show First 20 Lines • Show All 72 Lines • ▼ Show 20 Line(s)
73Comment[x-test]=xxBreeze by the KDE VDGxx 73​Comment[x-test]=xxBreeze by the KDE VDGxx
74Comment[zh_CN]=微风，由 KDE VDG 创作 74​Comment[zh_CN]=微风，由 KDE VDG 创作
75Comment[zh_TW]=由 KDE VDG 團隊製作的 Breeze 75​Comment[zh_TW]=由 KDE VDG 團隊製作的 Breeze
76 76​
77 77​
78X-KDE-PluginInfo-Author=KDE Visual Design Group 78​X-KDE-PluginInfo-Author=KDE Visual Design Group
79X-KDE-PluginInfo-Email=kde-artists@kde.org 79​X-KDE-PluginInfo-Email=kde-artists@kde.org
80X-KDE-PluginInfo-Name=default 80​X-KDE-PluginInfo-Name=default
81X-KDE-PluginInfo-Version=@KF5_VERSION@ 81​X-KDE-PluginInfo-Version=@KF5_VERSION@
davidedmundsonUnsubmitted
Done

This line needs restoring

davidedmundson: This line needs restoring
82X-KDE-PluginInfo-Website=https://plasma.kde.org 82​X-KDE-PluginInfo-Website=https://plasma.kde.org
83X-KDE-PluginInfo-Category= 83​X-KDE-PluginInfo-Category=
84X-KDE-PluginInfo-Depends= 84​X-KDE-PluginInfo-Depends=
85X-KDE-PluginInfo-License=LGPL 85​X-KDE-PluginInfo-License=LGPL
86X-KDE-PluginInfo-EnabledByDefault=true 86​X-KDE-PluginInfo-EnabledByDefault=true
87X-Plasma-API=5.0 87​X-Plasma-API=5.0
88 88​
89[Wallpaper] 89​[Wallpaper]
90defaultWallpaperTheme=Next 90​defaultWallpaperTheme=Next
91defaultFileSuffix=.png 91​defaultFileSuffix=.png
92defaultWidth=1920 92​defaultWidth=1920
93defaultHeight=1080 93​defaultHeight=1080
94 94​
95[ContrastEffect] 95​[ContrastEffect]
96enabled=true 96​enabled=true
97contrast=0.2 97​contrast=0.3
98#intensity is disabled, in order to auto adjust to the chosen theme color 98​intensity=1.4
davidedmundsonUnsubmitted
Not Done

There's an explicit comment on why this is as it is.

That needs some addressing as to why it no longer applies or is less important that some other change.

davidedmundson: There's an explicit comment on why this is as it is. That needs some addressing as to why it…
niccoloveAuthorUnsubmitted
Not Done

Simply put, it doesn't work. I opened a bug about it https://bugs.kde.org/show_bug.cgi?id=416699. It results in weird colors that have nothing to do with the background. If I understood it correctly, it's supposed to tweak the value based on the background darkness in order to make the background more light in those cases and preserving readability, but that does not seem to work either as there are some places in the 'before' screenshots that look way too dark, and are instead much more readable with this patch.

niccolove: Simply put, it doesn't work. I opened a bug about it https://bugs.kde.org/show_bug.cgi?
99#intensity=2.0 99​saturation=4.0
100saturation=1.7 ​