Differential D26047 Diff 74021 libnotificationmanager/settings.h

Changeset View

Standalone View

libnotificationmanager/settings.h

Show All 24 Lines
25	#include <KSharedConfig>	25		#include <KSharedConfig>
26		26
27	#include <QDateTime>	27		#include <QDateTime>
28	#include <QScopedPointer>	28		#include <QScopedPointer>
29	#include <QString>	29		#include <QString>
30		30
31	#include "notificationmanager_export.h"	31		#include "notificationmanager_export.h"
32		32
		33		class KCoreConfigSkeleton;
			ervinUnsubmitted Not Done This change isn't needed anymore. ervin: This change isn't needed anymore.
		34
33	namespace NotificationManager	35		namespace NotificationManager
34	{	36		{
35		37
36	/**	38		/**
37	* @short Notification settings and state	39		* @short Notification settings and state
38	*	40		*
39	* This class encapsulates all global settings related to notifications	41		* This class encapsulates all global settings related to notifications
40	* as well as do not disturb mode and other state.	42		* as well as do not disturb mode and other state.
▲ Show 20 Lines • Show All 292 Lines • ▼ Show 20 Line(s)		230	public:
333	/**	335		/**
334	* Revoke application notification inhibitions.	336		* Revoke application notification inhibitions.
335	*	337		*
336	* @note Applications are not notified of the fact that their	338		* @note Applications are not notified of the fact that their
337	* inhibition might have been taken away.	339		* inhibition might have been taken away.
338	*/	340		*/
339	Q_INVOKABLE void revokeApplicationInhibitions();	341		Q_INVOKABLE void revokeApplicationInhibitions();
340		342
341	signals:	343		signals:
			broulikUnsubmitted Not Done Not a fan of this becoming public API broulik: Not a fan of this becoming public API
			crossiAuthorUnsubmitted Not Done Maybe not the best approach. Any suggestion to access the KCoreConfigSkeleton encapsulated to register them in the KCM's ConfigModule ? crossi: Maybe not the best approach. Any suggestion to access the KCoreConfigSkeleton encapsulated to…
			ervinUnsubmitted Not Done @broulik I understand you don't like much this becoming exposed as one could abuse it to kill encapsulation and state... but we can't have it both ways either. This facade makes it impossible to plug as is in existing systems around KCM or ConfigModule without large efforts. I don't think we can have it both ways here. ervin: @broulik I understand you don't like much this becoming exposed as one could abuse it to kill…
			ervinUnsubmitted Not Done Will need API documentation ervin: Will need API documentation
342	void settingsChanged();	344		void settingsChanged();
343		345
344	void liveChanged();	346		void liveChanged();
345	void dirtyChanged();	347		void dirtyChanged();
346		348
347	void knownApplicationsChanged();	349		void knownApplicationsChanged();
348		350
349	void notificationsInhibitedByApplicationChanged(bool notificationsInhibitedByApplication);	351		void notificationsInhibitedByApplicationChanged(bool notificationsInhibitedByApplication);
Show All 13 Lines