Differential D2348 Diff 5660 plugins/extensions/waveletdecompose/waveletdecompose.cpp

Changeset View

Standalone View

View Options

plugins/extensions/waveletdecompose/waveletdecompose.cpp

  • This file was added.
1​/*
2​ * Copyright (C) 2016 Miroslav Talasek <miroslav.talasek@seznam.cz>
3​ *
4​ * This library is free software; you can redistribute it and/or
5​ * modify it under the terms of the GNU Library General Public
6​ * License as published by the Free Software Foundation; either
7​ * version 2 of the License, or (at your option) any later version.
8​ *
9​ * This library is distributed in the hope that it will be useful,
10​ * but WITHOUT ANY WARRANTY; without even the implied warranty of
11​ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
12​ * Library General Public License for more details.
13​ *
14​ * You should have received a copy of the GNU Library General Public License
15​ * along with this library; see the file COPYING.LIB. If not, write to
16​ * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
17​ * Boston, MA 02110-1301, USA.
18​ */
19​
20​#include "waveletdecompose.h"
21​
22​#include <QMap>
23​#include <QPointer>
24​#include <QHash>
25​
26​#include <klocalizedstring.h>
27​#include <kpluginfactory.h>
28​
29​#include <KoColorSpace.h>
30​#include <KoChannelInfo.h>
31​#include <KoColor.h>
32​
33​#include <kis_debug.h>
34​#include <kis_types.h>
35​#include <KisViewManager.h>
36​#include <kis_image.h>
37​#include <kis_wavelet_kernel.h>
38​#include <kis_action.h>
39​#include <KisDocument.h>
40​#include <kis_node.h>
41​#include <kis_painter.h>
42​#include <kis_paint_device.h>
43​#include <kis_paint_layer.h>
44​#include <kis_group_layer.h>
45​#include <kis_random_accessor_ng.h>
46​#include "dlg_waveletdecompose.h"
47​#include "kis_node_manager.h"
48​#include "kis_node_commands_adapter.h"
49​#include "kis_undo_adapter.h"
50​
51​#include <KoUpdater.h>
52​#include <KoProgressUpdater.h>
53​
54​#include <stdio.h>
55​
56​
57​#include <iostream>
58​
59​
60​K_PLUGIN_FACTORY_WITH_JSON(WaveletDecomposeFactory, "kritawaveletdecompose.json", registerPlugin<WaveletDecompose>();)
61​
62​WaveletDecompose::WaveletDecompose(QObject *parent, const QVariantList &)
63​ : KisViewPlugin(parent)
64​{
65​ KisAction *action = createAction("waveletdecompose");
66​ connect(action, SIGNAL(triggered()), this, SLOT(slotWaveletDecompose()));
67​}
68​
69​WaveletDecompose::~WaveletDecompose()
70​{
71​}
72​
73​
74​struct Layer {
75​ KoColor color;
76​ KisPaintDeviceSP device;
77​ KisRandomAccessorSP accessor;
78​ int pixelsWritten;
79​
80​ bool operator<(const Layer& other) const
81​ {
82​ return pixelsWritten < other.pixelsWritten;
83​ }
84​};
85​
86​void WaveletDecompose::slotWaveletDecompose()
dkazakovUnsubmitted
Not Done

It is better to change this line into image->barrierLock(), otherwise your action can interfere with the suspended strokes.

to all:
probably, we should rename image->lock() into something image->lockNoBarrierNeverUseUnlessYouReallyKnowWhatYouAreDoing() ? :)

dkazakov: It is better to change this line into `image->barrierLock()`, otherwise your action can…
miroslavtalasekUnsubmitted
Not Done

I copy paste from extension split layers whis is my start example

miroslavtalasek: I copy paste from extension split layers whis is my start example
87​{
88​
remptAuthorUnsubmitted
Not Done

Maybe lose a few empty lines here?

rempt: Maybe lose a few empty lines here?
89​
90​
91​
92​ DlgWaveletDecompose *dlg = new DlgWaveletDecompose(m_view->mainWindow(),"WaveletDecompose");
remptAuthorUnsubmitted
Not Done

I realize that there's a lot of places in Krita where we create dialogs this way, but "modern" thinking prefers to create dialogs on the stack, so you don't need to explicitly delete them -- that is helpful if later on there will be more than one exit location from this function.

rempt: I realize that there's a lot of places in Krita where we create dialogs this way, but "modern"…
93​
94​ if (dlg->exec() == QDialog::Accepted) {
95​
96​ dlg->hide();
remptAuthorUnsubmitted
Not Done

I'm suddenly unsure, but if the dialog is accepted, it's hidden already, isn't it?

rempt: I'm suddenly unsure, but if the dialog is accepted, it's hidden already, isn't it?
97​
98​ QApplication::setOverrideCursor(Qt::WaitCursor);
99​
100​ KoProgressUpdater* pu = m_view->createProgressUpdater(KoProgressUpdater::Unthreaded);
101​ pu->start(100, i18n("Wavelet Decompose"));
102​ QPointer<KoUpdater> updater = pu->startSubtask();
103​ updater->setProgress(0);
104​
105​ KisImageSP image = m_view->image();
106​ if (!image) return;
107​
108​ image->lock();
109​
110​
111​ KisLayerSP layer = m_view->activeLayer();
112​ if (!layer) return;
113​
114​ KisPaintDeviceSP projection = new KisPaintDevice(*(layer->projection()),false,0);
115​ if (!projection) return;
116​
117​ const KoColorSpace *cs = projection->colorSpace();
118​
119​ const KoCompositeOp* op = cs->compositeOp(COMPOSITE_GRAIN_EXTRACT);
120​
121​ int scales = dlg->scales();
122​
123​ QList<KisPaintDeviceSP> results;
124​ const QBitArray flags(0);
125​
126​
127​ QRect rc = image->bounds();
128​
129​ KisPaintDeviceSP original = projection;
130​
131​ //main loop
132​ for(int lev = 0; lev < scales; ++lev){
remptAuthorUnsubmitted
Not Done

if "lev" is meant to mean "level", just write it out in full.

rempt: if "lev" is meant to mean "level", just write it out in full.
133​
134​ //copy original
135​ KisPaintDeviceSP blur = new KisPaintDevice(*original,false,0);
remptAuthorUnsubmitted
Not Done

In general, don't forget to add a space after a comma, for readability.

rempt: In general, don't forget to add a space after a comma, for readability.
136​ //blur it
137​ KisWaveletKernel::applyWavelet(blur, rc,
138​ 1 << lev, 1 << lev,flags, 0);
139​ //do grain extract blur from original
140​
141​ KisPainter painter(original);
142​ painter.setCompositeOp(op);
143​ painter.bitBlt(0, 0, blur, 0, 0, rc.width(), rc.height());
144​ painter.end();
145​
146​ //original is new scale and blur is new original
147​ results << original;
148​ original = blur;
149​ updater->setProgress((lev * 100)/scales);
150​ }
151​ //add new layers
152​ KisUndoAdapter *undo = image->undoAdapter();
153​ undo->beginMacro(kundo2_i18n("Wavelet decompose"));
154​
155​ KisNodeCommandsAdapter adapter(m_view);
156​
157​ KisGroupLayerSP baseGroup = dynamic_cast<KisGroupLayer*>(layer->parent().data());
158​
159​ if (!baseGroup) {
160​ // Masks are never nested
161​ baseGroup = dynamic_cast<KisGroupLayer*>(layer->parent()->parent().data());
162​ }
163​ //add layer goup
164​ KisGroupLayerSP grp = new KisGroupLayer(image, i18n("Wavelet decompose"), OPACITY_OPAQUE_U8);
165​ adapter.addNode(grp, baseGroup, 1);
166​ baseGroup = grp;
167​
168​
169​ //add scales
170​ int i = 1;
171​ const KoCompositeOp* op2 = cs->compositeOp(COMPOSITE_GRAIN_MERGE);
172​ Q_FOREACH (const KisPaintDeviceSP &l, results) {
173​ KisPaintLayerSP paintLayer = new KisPaintLayer(image, QStringLiteral("Scale %1").arg(i), OPACITY_OPAQUE_U8, l);
174​ adapter.addNode(paintLayer, baseGroup, 0);
175​ adapter.setCompositeOp(paintLayer, op2);
176​ ++i;
177​ }
178​
179​ //add residual
180​ KisPaintLayerSP paintLayer = new KisPaintLayer(image, "Residual", OPACITY_OPAQUE_U8, original);
181​ adapter.addNode(paintLayer, baseGroup, 0);
182​
183​ undo->endMacro();
184​
185​ updater->setProgress(100);
186​ image->unlock();
187​ image->setModified();
188​ }
189​
190​ delete dlg;
191​ QApplication::restoreOverrideCursor();
192​}
193​
194​#include "waveletdecompose.moc"