Differential D26680 Diff 73589 kcms/feedback/feedback.cpp

Changeset View

Standalone View

kcms/feedback/feedback.cpp

Show All 34 Lines		33	Feedback::Feedback(QObject *parent, const QVariantList &args)
35	//UserFeedback.conf is used by KUserFeedback which uses QSettings and won't go through globals	35		//UserFeedback.conf is used by KUserFeedback which uses QSettings and won't go through globals
36	, m_plasmaConfig(KSharedConfig::openConfig(QStringLiteral("PlasmaUserFeedback")))	36		, m_plasmaConfig(KSharedConfig::openConfig(QStringLiteral("PlasmaUserFeedback")))
37	{	37		{
38	Q_UNUSED(args)	38		Q_UNUSED(args)
39	setAboutData(new KAboutData(QStringLiteral("kcm_feedback"),	39		setAboutData(new KAboutData(QStringLiteral("kcm_feedback"),
40	i18n("User Feedback"),	40		i18n("User Feedback"),
41	QStringLiteral("1.0"), i18n("Configure user feedback settings"), KAboutLicense::LGPL));	41		QStringLiteral("1.0"), i18n("Configure user feedback settings"), KAboutLicense::LGPL));
42		42
43	connect(this, &Feedback::plasmaFeedbackLevelChanged, this, [this](){	43		connect(this, &Feedback::plasmaFeedbackLevelChanged, this, [this](){
			mevenUnsubmitted Not Done nitpick, You could move this to `Feedback::setPlasmaFeedbackLevel` as well. 1 saves a connect, 2 make setRepresesentsDefault and setNeedsSave close in the file meven: nitpick, You could move this to `Feedback::setPlasmaFeedbackLevel` as well. 1 saves a connect…
			davidedmundsonAuthorUnsubmitted Not Done sorry I missed your comment. I'll make this change. davidedmundson: sorry I missed your comment. I'll make this change.
44	setNeedsSave(true);	44		setNeedsSave(true);
45	});	45		});
46	}	46		}
47		47
48	Feedback::~Feedback() = default;	48		Feedback::~Feedback() = default;
49		49
50	bool Feedback::feedbackEnabled() const	50		bool Feedback::feedbackEnabled() const
51	{	51		{
Show All 14 Lines		64	{
66	m_plasmaConfig->sync();	66		m_plasmaConfig->sync();
67	}	67		}
68		68
69	void Feedback::defaults()	69		void Feedback::defaults()
70	{	70		{
71	setPlasmaFeedbackLevel(KUserFeedback::Provider::NoTelemetry);	71		setPlasmaFeedbackLevel(KUserFeedback::Provider::NoTelemetry);
72	}	72		}
73		73
		74		void Feedback::setPlasmaFeedbackLevel(int plasmaFeedbackLevel) {
		75		if (plasmaFeedbackLevel != m_plasmaFeedbackLevel) {
		76		m_plasmaFeedbackLevel = plasmaFeedbackLevel;
		77		Q_EMIT plasmaFeedbackLevelChanged(plasmaFeedbackLevel);
		78		}
		79		setRepresentsDefaults(plasmaFeedbackLevel == KUserFeedback::Provider::NoTelemetry);
		80		}
		81
74	#include "feedback.moc"	82		#include "feedback.moc"