Differential D25449 Diff 70122 kcms/formats/localemodel.h

Changeset View

Standalone View

View Options

kcms/formats/localemodel.h

  • This file was added.
1​#ifndef LOCALEMODEL_H
2​#define LOCALEMODEL_H
broulikUnsubmitted
Not Done

Missing copyright header

broulik: Missing copyright header
3​
4​#include <QAbstractListModel>
5​#include <QIcon>
6​#include <QString>
7​#include <QVector>
8​#include <QPair>
9​#include <QByteArray>
broulikUnsubmitted
Not Done

Unused

broulik: Unused
10​#include <QHash>
11​
12​struct LocaleItem {
13​ QIcon flag;
14​ QString localeName;
15​ QString localeValue;
16​};
17​
broulikUnsubmitted
Done

declare as movable type

broulik: declare as movable type
18​class LocaleModel : public QAbstractListModel {
19​ Q_OBJECT
broulikUnsubmitted
Done

{ on new line

broulik: `{` on new line
20​public:
21​ enum {Flag = Qt::UserRole + 1, LocaleName, LocaleValue};
22​ LocaleModel(QObject *parent = nullptr);
broulikUnsubmitted
Done

Use Qt::DisplayRole for LocaleName

Also, what is this ominous "value"? Please give it a clearer name.
Also, coding style.

broulik: Use `Qt::DisplayRole` for `LocaleName` Also, what is this ominous "value"? Please give it a…
23​
broulikUnsubmitted
Done

explicit

broulik: `explicit`
24​ int rowCount(const QModelIndex& parent = QModelIndex()) const override;
25​ QVariant data(const QModelIndex& idx, int role) const override;
26​ QHash<int, QByteArray> roleNames() const override;
27​
28​ Q_INVOKABLE int indexFor(const QString& value) const;
29​ Q_INVOKABLE QString valueFor(int idx) const;
davidedmundsonUnsubmitted
Done

this is duplicating data() no?

davidedmundson: this is duplicating data() no?
30​private:
31​ QVector<LocaleItem> m_data;
32​};
33​
34​#endif