Differential D24743 Diff 69141 kded-module/configeditor.cpp

Changeset View

Standalone View

View Options

kded-module/configeditor.cpp

  • This file was added.
1​/*
2​ * Copyright (C) 2019 Mikhail Zolotukhin <zomial@protonmail.com>
3​ *
4​ * This program is free software; you can redistribute it and/or
5​ * modify it under the terms of the GNU General Public License as
6​ * published by the Free Software Foundation; either version 2 of
7​ * the License or (at your option) version 3 or any later version
8​ * accepted by the membership of KDE e.V. (or its successor approved
9​ * by the membership of KDE e.V.), which shall act as a proxy
10​ * defined in Section 14 of version 3 of the license.
11​ *
12​ * This program is distributed in the hope that it will be useful,
13​ * but WITHOUT ANY WARRANTY; without even the implied warranty of
14​ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15​ * GNU General Public License for more details.
16​ *
17​ * You should have received a copy of the GNU General Public License
18​ * along with this program. If not, see <http://www.gnu.org/licenses/>.
19​ */
20​
21​#include <QDebug>
22​#include <QDir>
23​#include <QRegularExpression>
24​#include <QStandardPaths>
25​#include <QProcess>
26​
27​#include <KSharedConfig>
28​#include <KConfigGroup>
29​
30​#include <string>
31​#include <csignal>
32​#include <cstdio>
33​
34​#include <gio/gio.h>
35​#include <gtk/gtk.h>
broulikUnsubmitted
Done

Alternatively you could compile the project with QT_NO_KEYWORDS

broulik: Alternatively you could compile the project with `QT_NO_KEYWORDS`
36​
37​#include "configeditor.h"
38​
39​static void replaceValueInGtkrcContents(QString &gtkrcContents, const QString &paramName, const QString &paramValue);
40​static void replaceValueInXSettingsdContents(QString &xSettingsdContents, const QString &paramName, const QString &paramValue);
41​
42​static void reloadGtk2Apps();
43​static void reloadXSettingsd();
44​
45​static QString readFileContents(QFile &gtkrc);
46​static pid_t pidOfXSettingsd();
47​
48​
49​void ConfigEditor::setGtk3ConfigValueDconf(const QString &paramName, const QString &paramValue)
50​{
ervinUnsubmitted
Done

Better wrap the const char* in a QStringLiteral.

Also, but more of a nitpick this time: style wise I'd favor using = for those initialization (and others in the file) than parenthesis. It gets too close the most vexing parse territory, I'd rather not potentially expose a future developer touching that file to it.

ervin: Better wrap the const char* in a QStringLiteral. Also, but more of a nitpick this time: style…
gikariAuthorUnsubmitted
Done

Where generally should I use equals sign (=), where parenthesis (()) and where braces ({}) for initialization? I didn't find any note about that in coding style.

gikari: Where generally should I use equals sign (`=`), where parenthesis (`()`) and where braces…
ngrahamUnsubmitted
Done

I believe in general use equals, but you can use braces for lists.

ngraham: I believe in general use equals, but you can use braces for lists.
51​ gtk_init(nullptr, nullptr);
52​ g_autoptr(GSettings) gsettings = g_settings_new("org.gnome.desktop.interface");
53​ g_settings_set_string(gsettings, paramName.toUtf8().constData(), paramValue.toUtf8().constData());
54​}
55​
56​void ConfigEditor::setGtk3ConfigValueSettingsIni(const QString &paramName, const QString &paramValue)
57​{
58​ QString configLocation = QStandardPaths::writableLocation(QStandardPaths::GenericConfigLocation);
59​ QString gtk3ConfigPath = configLocation + QStringLiteral("/gtk-3.0/settings.ini");
60​
61​ KSharedConfig::Ptr gtk3Config = KSharedConfig::openConfig(gtk3ConfigPath, KConfig::NoGlobals);
62​ KConfigGroup group = gtk3Config->group(QStringLiteral("Settings"));
63​
64​ group.writeEntry(paramName, paramValue);
65​ group.sync();
66​}
67​
68​void ConfigEditor::setGtk3ConfigValueXSettingsd(const QString &paramName, const QString &paramValue)
69​{
70​ using qsp = QStandardPaths;
71​ QString configLocation = qsp::writableLocation(qsp::GenericConfigLocation);
72​
73​ QDir xsettingsdPath = configLocation + QStringLiteral("/xsettingsd");
74​ if (!xsettingsdPath.exists()) {
75​ xsettingsdPath.mkpath(QStringLiteral("."));
76​ }
77​
78​ QString xSettingsdConfigPath = xsettingsdPath.path() + QStringLiteral("/xsettingsd.conf");
79​
80​ QFile xSettingsdConfig(xSettingsdConfigPath);
81​ QString xSettingsdConfigContents = readFileContents(xSettingsdConfig);
82​ replaceValueInXSettingsdContents(xSettingsdConfigContents, paramName, paramValue);
ervinUnsubmitted
Done

QStringLiteral please.

ervin: QStringLiteral please.
83​ xSettingsdConfig.remove();
84​ xSettingsdConfig.open(QIODevice::WriteOnly | QIODevice::Text);
85​ xSettingsdConfig.write(xSettingsdConfigContents.toUtf8());
86​ reloadXSettingsd();
87​}
88​
89​void ConfigEditor::setGtk2ConfigValue(const QString &paramName, const QString &paramValue)
90​{
91​ QString gtkrcPath = QDir::homePath() + QStringLiteral("/.gtkrc-2.0");
92​ QFile gtkrc(gtkrcPath);
93​ QString gtkrcContents = readFileContents(gtkrc);
94​ replaceValueInGtkrcContents(gtkrcContents, paramName, paramValue);
95​ gtkrc.remove();
96​ gtkrc.open(QIODevice::WriteOnly | QIODevice::Text);
97​ gtkrc.write(gtkrcContents.toUtf8());
ervinUnsubmitted
Done

QString() or {} instead of ""

ervin: QString() or {} instead of ""
98​ reloadGtk2Apps();
99​}
100​
101​static QString readFileContents(QFile &file)
102​{
103​ if (file.open(QIODevice::ReadWrite | QIODevice::Text)) {
ervinUnsubmitted
Done

QStringLiteral please

There are more of those in the file, I'll stop pointing them out. ;-)

ervin: QStringLiteral please There are more of those in the file, I'll stop pointing them out. ;-)
104​ return file.readAll();
105​ } else {
106​ return QString();
broulikUnsubmitted
Done

make static so it doesn't have to recreate it every time?

broulik: make `static` so it doesn't have to recreate it every time?
107​ }
108​}
109​
110​static void replaceValueInGtkrcContents(QString &gtkrcContents, const QString &paramName, const QString &paramValue)
111​{
112​ const QRegularExpression regExp(paramName + QStringLiteral("=[^\n]*($|\n)"));
113​
114​ static const QStringList nonStringProperties{
115​ QStringLiteral("gtk-toolbar-style"),
116​ QStringLiteral("gtk-menu-images"),
117​ QStringLiteral("gtk-button-images"),
118​ QStringLiteral("gtk-primary-button-warps-slider"),
119​ };
120​
121​ QString newConfigString;
122​ if (nonStringProperties.contains(paramName)) {
123​ newConfigString = paramName + QStringLiteral("=") + paramValue + QStringLiteral("\n");
124​ } else {
125​ newConfigString = paramName + QStringLiteral("=\"") + paramValue + QStringLiteral("\"\n");
126​ }
127​
128​ if (gtkrcContents.contains(regExp)) {
129​ gtkrcContents.replace(regExp, newConfigString);
130​ } else {
131​ gtkrcContents = newConfigString + QStringLiteral("\n") + gtkrcContents;
132​ }
133​}
134​
135​static void replaceValueInXSettingsdContents(QString &xSettingsdContents, const QString &paramName, const QString &paramValue)
136​{
137​ const QRegularExpression regExp(paramName + QStringLiteral(" [^\n]*($|\n)"));
138​
139​ static const QStringList nonStringProperties{
140​ QStringLiteral("Gtk/ButtonImages"),
141​ QStringLiteral("Gtk/MenuImages"),
142​ QStringLiteral("Gtk/ToolbarStyle"),
143​ };
144​
145​ QString newConfigString;
146​ if (nonStringProperties.contains(paramName)) {
147​ newConfigString = paramName + QStringLiteral(" ") + paramValue + QStringLiteral("\n");
148​ } else {
149​ newConfigString = paramName + QStringLiteral(" \"") + paramValue + QStringLiteral("\"\n");
150​ }
151​
152​ if (xSettingsdContents.contains(regExp)) {
153​ xSettingsdContents.replace(regExp, newConfigString);
154​ } else {
155​ xSettingsdContents = newConfigString + QStringLiteral("\n") + xSettingsdContents;
156​ }
157​}
158​
159​static void reloadGtk2Apps()
160​{
161​ QProcess::startDetached(QStandardPaths::findExecutable(QStringLiteral("reload_gtk_apps")));
162​}
163​
164​static void reloadXSettingsd()
165​{
166​ pid_t xSettingsdPid = pidOfXSettingsd();
167​ if (xSettingsdPid == 0) {
168​ QProcess::startDetached(QStandardPaths::findExecutable(QStringLiteral("xsettingsd")));
169​ } else {
170​ kill(xSettingsdPid, SIGHUP);
171​ }
broulikUnsubmitted
Done

I would prefer using more higher level QProcess here

broulik: I would prefer using more higher level `QProcess` here
172​}
173​
174​static pid_t pidOfXSettingsd()
175​{
176​ QProcess pidof {};
177​ pidof.start(QStringLiteral("pidof"), QStringList() << QStringLiteral("-s") << QStringLiteral("xsettingsd"));
nicolasfellaUnsubmitted
Done

QProcess pidof;

nicolasfella: QProcess pidof;
178​ pidof.waitForFinished();
179​ QString xsettingsdPid = QString(pidof.readAllStandardOutput()).remove('\n');
180​ return xsettingsdPid.toInt();
181​}