Differential D24856 Diff 68987 ksplash/ksplashqml/ksplashqml.desktop.cmake

Changeset View

Standalone View

View Options

ksplash/ksplashqml/ksplashqml.desktop.cmake

  • This file was added.
1​[Desktop Entry]
2​Exec=@CMAKE_INSTALL_PREFIX@/bin/ksplashqml
3​GenericName=Plasma Qml Splash Screen
4​Name=ksplashqml
ngrahamUnsubmitted
Done

Human readable name please

ngraham: Human readable name please
mevenAuthorUnsubmitted
Not Done

I have added GenericName which serves this purpose.
But this desktop files won't be visible by users thanks to "NoDisplay".

meven: I have added GenericName which serves this purpose. But this desktop files won't be visible by…
5​NoDisplay=true
6​Type=Application
7​X-KDE-Wayland-Interfaces=org_kde_plasma_window_management
apolUnsubmitted
Not Done

Are you sure the wayland interface is required?

It seems like the warning is broken, so we could just as well remove it.

apol: Are you sure the wayland interface is required? It seems like the warning is broken, so we…
mevenAuthorUnsubmitted
Not Done

I agree, it seems org_kde_plasma_window_management is so simple we should grant it to all windows by default without this warning.

meven: I agree, it seems `org_kde_plasma_window_management` is so simple we should grant it to all…
8​
mevenAuthorUnsubmitted
Not Done

I think X-DBUS-* may not be necessary here.

meven: I think X-DBUS-* may not be necessary here.