Differential D24856

Add a .desktop file to ksplashqml
Needs ReviewPublic
Actions

Authored by meven on Oct 22 2019, 10:11 AM.

Details

Reviewers
apol
Group Reviewers
Plasma
Summary

To prevent warnings in kwin such as :
kwin_core: Did not grant the interface "org_kde_plasma_window_management" to "/home/meven/kde/usr/bin/ksplashqml" . Please request it under X-KDE-Wayland-Interfaces

Diff Detail

Repository
R120 Plasma Workspace
Branch
arcpatch-D24856_2
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 18317
Build 18335: arc lint + arc unit
meven created this revision.Oct 22 2019, 10:11 AM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 22 2019, 10:11 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
meven requested review of this revision.Oct 22 2019, 10:11 AM
ngraham added a subscriber: ngraham.Oct 22 2019, 1:57 PM
ngraham added inline comments.
ksplash/ksplashqml/ksplashqml.desktop.cmake
4

Human readable name please

meven updated this revision to Diff 68737.Oct 25 2019, 9:40 AM

Add GenericName

meven updated this revision to Diff 68738.Oct 25 2019, 9:45 AM

Rebase on master

meven marked an inline comment as done.Oct 25 2019, 10:03 AM
meven added inline comments.
ksplash/ksplashqml/ksplashqml.desktop.cmake
4

I have added GenericName which serves this purpose.
But this desktop files won't be visible by users thanks to "NoDisplay".

9

I think X-DBUS-* may not be necessary here.

meven updated this revision to Diff 68987.Oct 29 2019, 5:36 PM
meven marked an inline comment as done.

ksplashqml is not a dbus service

apol added inline comments.Oct 30 2019, 12:34 PM
ksplash/ksplashqml/ksplashqml.desktop.cmake
7

Are you sure the wayland interface is required?

It seems like the warning is broken, so we could just as well remove it.

meven added inline comments.Jan 21 2020, 1:07 PM
ksplash/ksplashqml/ksplashqml.desktop.cmake
7

I agree, it seems org_kde_plasma_window_management is so simple we should grant it to all windows by default without this warning.

Revision Contents
Changeset List

Diff 68987

View Options

ksplash/ksplashqml/CMakeLists.txt

Loading...
View Options

ksplash/ksplashqml/ksplashqml.desktop.cmake

Loading...