Changeset View
Changeset View
Standalone View
Standalone View
src/khtmlview.cpp
Show First 20 Lines • Show All 3121 Lines • ▼ Show 20 Line(s) | 3117 | public: | |||
---|---|---|---|---|---|
3122 | } | 3122 | } | ||
3123 | private: | 3123 | private: | ||
3124 | const QPointer<QObject> obj; | 3124 | const QPointer<QObject> obj; | ||
3125 | }; | 3125 | }; | ||
3126 | } | 3126 | } | ||
3127 | 3127 | | |||
3128 | void KHTMLView::print(bool quick) | 3128 | void KHTMLView::print(bool quick) | ||
3129 | { | 3129 | { | ||
3130 | QPrinter printer; | ||||
3131 | print(&printer, quick); | ||||
3132 | } | ||||
3133 | | ||||
3134 | void KHTMLView::print(QPrinter *_printer, bool quick) | ||||
3135 | { | ||||
3130 | if (!m_part->xmlDocImpl()) { | 3136 | if (!m_part->xmlDocImpl()) { | ||
3131 | return; | 3137 | return; | ||
3132 | } | 3138 | } | ||
3133 | khtml::RenderCanvas *root = static_cast<khtml::RenderCanvas *>(m_part->xmlDocImpl()->renderer()); | 3139 | khtml::RenderCanvas *root = static_cast<khtml::RenderCanvas *>(m_part->xmlDocImpl()->renderer()); | ||
3134 | if (!root) { | 3140 | if (!root) { | ||
tbaumgart: Why don't you pass a reference to the QPrinter object here? | |||||
Because api dealing with QPrinter always use a pointer. void QWebView::print(QPrinter *) habacker: Because api dealing with QPrinter always use a pointer.
void QWebView::print(QPrinter *)… | |||||
3135 | return; | 3141 | return; | ||
3136 | } | 3142 | } | ||
3137 | 3143 | | |||
3138 | QPrinter printer; | 3144 | QPrinter &printer = *_printer; | ||
3139 | QPointer<QPrintDialog> dialog(new QPrintDialog(&printer, this)); | 3145 | QPointer<QPrintDialog> dialog(new QPrintDialog(&printer, this)); | ||
3140 | QPointer<KHTMLPrintSettings> printSettings(new KHTMLPrintSettings(dialog)); //XXX: doesn't save settings between prints like this | 3146 | QPointer<KHTMLPrintSettings> printSettings(new KHTMLPrintSettings(dialog)); //XXX: doesn't save settings between prints like this | ||
3141 | dialog->setOptionTabs(QList<QWidget *>() << printSettings.data()); | 3147 | dialog->setOptionTabs(QList<QWidget *>() << printSettings.data()); | ||
3142 | 3148 | | |||
3143 | const QPointerDeleter dialogDeleter(dialog); | 3149 | const QPointerDeleter dialogDeleter(dialog); | ||
3144 | 3150 | | |||
3145 | QString docname = m_part->xmlDocImpl()->URL().toDisplayString(); | 3151 | QString docname = m_part->xmlDocImpl()->URL().toDisplayString(); | ||
3146 | if (!docname.isEmpty()) { | 3152 | if (!docname.isEmpty()) { | ||
▲ Show 20 Lines • Show All 1377 Lines • Show Last 20 Lines |
Why don't you pass a reference to the QPrinter object here?