Differential D24743 Diff 68260 kded-module/configvalueprovider.h

Changeset View

Standalone View

View Options

kded-module/configvalueprovider.h

  • This file was added.
1​/*
2​ * Copyright (C) 2019 Mikhail Zolotukhin <zomial@protonmail.com>
broulikUnsubmitted
Done

Missing copyright header

broulik: Missing copyright header
3​ *
4​ * This program is free software; you can redistribute it and/or
5​ * modify it under the terms of the GNU General Public License as
6​ * published by the Free Software Foundation; either version 2 of
7​ * the License or (at your option) version 3 or any later version
8​ * accepted by the membership of KDE e.V. (or its successor approved
9​ * by the membership of KDE e.V.), which shall act as a proxy
10​ * defined in Section 14 of version 3 of the license.
11​ *
broulikUnsubmitted
Done

We typically don't use all caps for enums

broulik: We typically don't use all caps for enums
12​ * This program is distributed in the hope that it will be useful,
13​ * but WITHOUT ANY WARRANTY; without even the implied warranty of
14​ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15​ * GNU General Public License for more details.
16​ *
17​ * You should have received a copy of the GNU General Public License
18​ * along with this program. If not, see <http://www.gnu.org/licenses/>.
19​ */
20​
21​#pragma once
22​
23​class QString;
broulikUnsubmitted
Done

All of those const?

broulik: All of those `const`?
24​class QFont;
25​
26​class ConfigValueProvider
27​{
28​public:
29​ enum class ToolbarStyleNotation {
30​ Xsettingsd = 0,
31​ SettingsIni,
32​ Dconf
33​ };
34​
35​ ConfigValueProvider() = default;
36​
37​ QString getConfigFontName() const;
ervinUnsubmitted
Done

We don't prefix getters with get

Beside none of those have any state AFAICT, why not make them static or turn this into a namespace?

ervin: We don't prefix getters with get Beside none of those have any state AFAICT, why not make them…
38​ QString getConfigIconThemeName() const;
39​ QString getConfigCursorThemeName() const;
40​ QString getIconsOnButtonsConfigValue() const;
41​ QString getIconsInMenusConfigValue() const;
42​ QString getToolbarStyle(ToolbarStyleNotation notation) const;
43​
44​private:
45​ QString getToolbarStyleInDesiredNotation(const QString &kdeConfigValue, ToolbarStyleNotation notation) const;
46​
47​};