Differential D24743 Diff 68187 kded-module/configvalueprovider.h

Changeset View

Standalone View

1		#pragma once
	broulikUnsubmitted Done Missing copyright header broulik: Missing copyright header
2
3		class QString;
4		class QFont;
5
6		class ConfigValueProvider
7		{
8		public:
9		enum class ToolbarStyleNotation {
10		XSETTINGSD = 0,
	broulikUnsubmitted Done We typically don't use all caps for enums broulik: We typically don't use all caps for enums
11		SETTINGS_INI,
12		DCONF
13		};
14
15		ConfigValueProvider() = default;
16
17		QString getConfigFontName(const QFont &font);
18		QString getConfigIconThemeName();
19		QString getConfigCursorThemeName();
20		QString getIconsOnButtonsConfigValue();
21		QString getIconsInMenusConfigValue();
22		QString getToolbarStyle(ToolbarStyleNotation notation);
	broulikUnsubmitted Done All of those `const`? broulik: All of those `const`?
23
24		private:
25		QString getToolbarStyleInDesiredNotation(const QString &kdeConfigValue, ToolbarStyleNotation notation);
26
27		};
	ervinUnsubmitted Done We don't prefix getters with get Beside none of those have any state AFAICT, why not make them static or turn this into a namespace? ervin: We don't prefix getters with get Beside none of those have any state AFAICT, why not make them…