Differential D24743 Diff 68187 kded-module/configvalueprovider.cpp

Changeset View

Standalone View

View Options

kded-module/configvalueprovider.cpp

  • This file was added.
1​/*
2​ * Copyright (C) 2019 Mikhail Zolotukhin <zomial@protonmail.com>
3​ *
4​ * This program is free software; you can redistribute it and/or
5​ * modify it under the terms of the GNU General Public License as
6​ * published by the Free Software Foundation; either version 2 of
7​ * the License or (at your option) version 3 or any later version
8​ * accepted by the membership of KDE e.V. (or its successor approved
9​ * by the membership of KDE e.V.), which shall act as a proxy
10​ * defined in Section 14 of version 3 of the license.
11​ *
12​ * This program is distributed in the hope that it will be useful,
13​ * but WITHOUT ANY WARRANTY; without even the implied warranty of
14​ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15​ * GNU General Public License for more details.
16​ *
17​ * You should have received a copy of the GNU General Public License
18​ * along with this program. If not, see <http://www.gnu.org/licenses/>.
19​ */
20​
21​#include <QFont>
22​#include <QString>
23​
24​#include <KConfig>
25​#include <KIconTheme>
26​#include <KSharedConfig>
27​#include <KConfigGroup>
28​
29​#include "configvalueprovider.h"
30​
31​QString ConfigValueProvider::getConfigFontName(const QFont &font)
32​{
33​ return font.family() + ' ' + font.styleName() + ' ' + QString::number(font.pointSize());
34​}
35​
36​QString ConfigValueProvider::getConfigIconThemeName()
ervinUnsubmitted
Done

I will contradict my previous comment about making those functions static or turning into a namespace. I think it'd be better to avoid creating and ditching those KSharedConfig instances at each call, so why not instantiate it when ConfigValueProvider is created?

You might have to load() from the config at right point in times though.

ervin: I will contradict my previous comment about making those functions static or turning into a…
37​{
38​ KIconTheme *newIconTheme(KIconLoader::global()->theme());
broulikUnsubmitted
Done

theme() can return null

broulik: `theme()` can return null
39​ return newIconTheme->internalName();
40​}
41​
42​QString ConfigValueProvider::getConfigCursorThemeName()
43​{
44​ KSharedConfigPtr config(KSharedConfig::openConfig(QStringLiteral("kcminputrc")));
45​ KConfigGroup configGroup(config->group(QStringLiteral("Mouse")));
46​ return configGroup.readEntry(QStringLiteral("cursorTheme"));
47​}
48​
49​QString ConfigValueProvider::getIconsOnButtonsConfigValue()
50​{
51​ KSharedConfigPtr config(KSharedConfig::openConfig(QStringLiteral("kdeglobals"), KConfig::NoGlobals));
52​ KConfigGroup configGroup(config->group(QStringLiteral("KDE")));
53​ QString kdeConfigValue(configGroup.readEntry(QStringLiteral("ShowIconsOnPushButtons")));
broulikUnsubmitted
Done

Pass true as second argument (which is the default), then it will return you a bool directly.

broulik: Pass `true` as second argument (which is the default), then it will return you a `bool`…
54​
nicolasfellaUnsubmitted
Done

if (!newIconTheme)

nicolasfella: if (!newIconTheme)
55​ if (kdeConfigValue == QStringLiteral("true")) {
56​ return QStringLiteral("1");
57​ } else {
58​ return QStringLiteral("0");
59​ }
60​}
61​
62​QString ConfigValueProvider::getIconsInMenusConfigValue()
63​{
64​ KSharedConfigPtr config(KSharedConfig::openConfig(QStringLiteral("kdeglobals"), KConfig::NoGlobals));
65​ KConfigGroup configGroup(config->group(QStringLiteral("KDE")));
66​ QString kdeConfigValue(configGroup.readEntry(QStringLiteral("ShowIconsInMenuItems")));
67​
68​ if (kdeConfigValue == QStringLiteral("true")) {
69​ return QStringLiteral("1");
70​ } else {
71​ return QStringLiteral("0");
72​ }
73​}
74​
75​QString ConfigValueProvider::getToolbarStyle(ConfigValueProvider::ToolbarStyleNotation notation)
76​{
77​ KSharedConfigPtr config(KSharedConfig::openConfig(QStringLiteral("kdeglobals"), KConfig::NoGlobals));
78​ KConfigGroup configGroup(config->group(QStringLiteral("Toolbar style")));
79​ QString kdeConfigValue(configGroup.readEntry(QStringLiteral("ToolButtonStyle")));
broulikUnsubmitted
Done

Default value TextBesideIcon

broulik: Default value `TextBesideIcon`
80​ return getToolbarStyleInDesiredNotation(kdeConfigValue, notation);
81​}
82​
83​QString ConfigValueProvider::getToolbarStyleInDesiredNotation(const QString &kdeConfigValue, ConfigValueProvider::ToolbarStyleNotation notation)
84​{
85​ QStringList toolbarStyles;
86​ if (notation == ToolbarStyleNotation::SETTINGS_INI) {
87​ toolbarStyles.append({"GTK_TOOLBAR_ICONS", "GTK_TOOLBAR_TEXT", "GTK_TOOLBAR_BOTH_HORIZ", "GTK_TOOLBAR_BOTH"});
88​ } else if (notation == ToolbarStyleNotation::XSETTINGSD) {
89​ toolbarStyles.append({"0", "1", "3", "2"});
90​ } else {
91​ toolbarStyles.append({"icons", "text", "both-horiz", "both"});
92​ }
93​
94​ if (kdeConfigValue == QStringLiteral("NoText")) {
95​ return toolbarStyles[0];
96​ } else if (kdeConfigValue == QStringLiteral("TextOnly")) {
97​ return toolbarStyles[1];
98​ } else if (kdeConfigValue == QStringLiteral("TextBesideIcon")) {
99​ return toolbarStyles[2];
100​ } else {
101​ return toolbarStyles[3];
102​ }
103​}