Differential D23718 Diff 67701 kcms/baloo/package/contents/ui/main.qml

Changeset View

Standalone View

View Options

kcms/baloo/package/contents/ui/main.qml

  • This file was added.
1​/*
2​ * Copyright 2018 Tomaz Canabrava <tcanabrava@kde.org>
3​ *
GB_2Unsubmitted
Done

Shouldn't this be you copyright?

GB_2: Shouldn't this be you copyright?
ngrahamUnsubmitted
Done

Not done yet

ngraham: Not done yet
4​ * This program is free software; you can redistribute it and/or
5​ * modify it under the terms of the GNU General Public License as
6​ * published by the Free Software Foundation; either version 2 of
7​ * the License or (at your option) version 3 or any later version
8​ * accepted by the membership of KDE e.V. (or its successor approved
9​ * by the membership of KDE e.V.), which shall act as a proxy
10​ * defined in Section 14 of version 3 of the license.
11​ *
12​ * This program is distributed in the hope that it will be useful,
13​ * but WITHOUT ANY WARRANTY; without even the implied warranty of
14​ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15​ * GNU General Public License for more details.
16​ *
17​ * You should have received a copy of the GNU General Public License
18​ * along with this program. If not, see <http://www.gnu.org/licenses/>.
19​ */
20​
21​import QtQuick 2.1
22​import QtQuick.Layouts 1.1
23​import QtQuick.Controls 2.11 as QQC2
24​import QtQuick.Dialogs 1.2 as QtDialogs
ngrahamUnsubmitted
Done

IIRC plasma isn't depending on Qt 5.12 yet, right?

ngraham: IIRC plasma isn't depending on Qt 5.12 yet, right?
25​import org.kde.kirigami 2.4 as Kirigami
26​import org.kde.kcm 1.1 as KCM
27​import Qt.labs.platform 1.1
GB_2Unsubmitted
Not Done

Is this actually used? Also, because it's not installed by default it shows an error.

GB_2: Is this actually used? Also, because it's not installed by default it shows an error.
ngrahamUnsubmitted
Not Done

Fixed in https://commits.kde.org/plasma-desktop/659a46aac39789c40e8cd07060e3bacd5fe8d461

ngraham: Fixed in https://commits.kde.org/plasma-desktop/659a46aac39789c40e8cd07060e3bacd5fe8d461
28​
29​KCM.SimpleKCM {
30​ id: root
31​
32​ KCM.ConfigModule.quickHelp: i18n("This module lets you configure the file indexer and search functionality.")
33​ ColumnLayout {
ngrahamUnsubmitted
Done

"This module lets you configure the file indexer and search functionality."

ngraham: "This module lets you configure the file indexer and search functionality."
34​ anchors.fill: parent
35​ anchors.margins: Kirigami.Units.largeSpacing
36​
37​ QQC2.Label {
ngrahamUnsubmitted
Done

This item isn't inside a Layout, so Layout.<anything> has no effect. You want anchors.<whatever> instead.

Also the margins should be Kirigami.Units.largeSpacing.

ngraham: This item isn't inside a Layout, so `Layout.<anything>` has no effect. You want `anchors.
38​ text: i18n("File Search helps you quickly locate all your files based on their content.")
39​ }
40​
ngrahamUnsubmitted
Done

This is a sentence, so it needs to end with a period.

ngraham: This is a sentence, so it needs to end with a period.
41​ QQC2.CheckBox {
42​ id: fileSearchEnabled
43​ text: i18n("Enable File Search")
44​ checked: kcm.indexing
45​ onCheckStateChanged: {
46​ kcm.indexing = checked
47​ }
48​ }
ngrahamUnsubmitted
Not Done

This can be simplified to just if (!checked)

ngraham: This can be simplified to just `if (!checked)`
49​
50​ QQC2.CheckBox {
51​ id: indexFileContents
ngrahamUnsubmitted
Not Done

Don't need to reference it with fileSearchEnabled, just do kcm.indexing = checked

ngraham: Don't need to reference it with `fileSearchEnabled`, just do `kcm.indexing = checked`
52​ text: i18n("Also index file content")
53​ enabled: fileSearchEnabled.checked
54​ checked: kcm.fileContents
ngrahamUnsubmitted
Done

Don't do it this way, just use a binding:

checked: kcm.indexing

ngraham: Don't do it this way, just use a binding: `checked: kcm.indexing`
55​ onCheckStateChanged: kcm.fileContents = checked
56​ }
57​ Item {
58​ Layout.preferredHeight: Kirigami.Units.gridUnit
59​ }
60​ QQC2.Label {
61​ text: "Do not search in these locations:"
62​ }
63​
64​ QQC2.ScrollView {
65​ id: bgObject
66​ Component.onCompleted: bgObject.background.visible = true
67​ Layout.fillWidth: true
68​ Layout.fillHeight: true
69​
70​ ListView {
ngrahamUnsubmitted
Done

Same comments as with the first checkbox

ngraham: Same comments as with the first checkbox
71​ id: fileExcludeList
72​ anchors.fill: parent
ngrahamUnsubmitted
Done

I would add some spacing between the last checkbox and the list view's explanatory label:

Item {
    Layout.preferredHeight: Kirigami.Units.gridUnit
}
ngraham: I would add some spacing between the last checkbox and the list view's explanatory label: ```…
73​
74​ model: kcm.filteredModel
75​ delegate: Kirigami.BasicListItem {
76​ icon: model.decoration
77​ label: model.folder
78​ onClicked: fileExcludeList.currentIndex = index
79​ }
80​ }
81​ }
82​
83​ RowLayout {
84​ QQC2.Button {
85​ id: addFolder
86​ icon.name: "list-add"
87​ onClicked: fileDialogLoader.active = true
88​ }
89​
90​ QQC2.Button{
91​ id: removeFolder
92​ icon.name: "list-remove"
93​ enabled: fileExcludeList.currentIndex !== -1
94​ onClicked: {
95​ kcm.filteredModel.removeFolder(fileExcludeList.currentIndex)
96​ }
97​ }
98​ }
99​ }
100​
101​ Loader {
102​ id: fileDialogLoader
103​ active: false
104​ sourceComponent: QtDialogs.FileDialog {
105​ title: i18n("Select a folder to filter")
106​ folder: shortcuts.home
107​ selectFolder: true
108​
109​ onAccepted: {
110​ kcm.filteredModel.addFolder(fileUrls[0])
111​ fileDialogLoader.active = false
112​ }
113​
114​ onRejected: {
115​ fileDialogLoader.active = false
116​ }
117​
118​ Component.onCompleted: open()
119​ }
120​ }
121​}