WIP: Beginning of the Baloo/Search KCM Rewrite
Needs RevisionPublic

Authored by tcanabrava on Wed, Sep 4, 2:39 PM.

Details

Reviewers
mart
ngraham
Group Reviewers
Plasma
Maniphest Tasks
T7271: File Search
Summary

Closes T7271

Diff Detail

Repository
R119 Plasma Desktop
Branch
kcm_baloo_qml
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 16652
Build 16670: arc lint + arc unit
tcanabrava created this revision.Wed, Sep 4, 2:39 PM
Restricted Application added a project: Plasma. · View Herald TranscriptWed, Sep 4, 2:39 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
tcanabrava requested review of this revision.Wed, Sep 4, 2:39 PM
ngraham added a subscriber: ngraham.Wed, Sep 4, 2:41 PM
ngraham added inline comments.
kcms/baloo/package/ui/main.qml
23 ↗(On Diff #65369)

import QtQuick.Controls 2.5 as QQC2 (See T10862)

mart added a subscriber: mart.Wed, Sep 4, 2:42 PM
mart added inline comments.
kcms/baloo/package/ui/main.qml
33 ↗(On Diff #65369)

should use a Kirigami.FormLayout to have checkboxes centered?

mart added a comment.Wed, Sep 4, 2:42 PM

please, include screenshots

ngraham added inline comments.Wed, Sep 4, 3:29 PM
kcms/baloo/package/ui/main.qml
31 ↗(On Diff #65369)

While we're at it, let's improve this string:

"This module lets you configure the system-wide file search features"

tcanabrava updated this revision to Diff 65375.Wed, Sep 4, 4:18 PM
  • Fix metadata installation
  • Fix model loading on Qml
  • Base work on the Qml
tcanabrava updated this revision to Diff 65378.Wed, Sep 4, 4:35 PM
  • Name fixes
ngraham edited the summary of this revision. (Show Details)Thu, Sep 5, 4:27 PM
ngraham added a reviewer: Plasma.
tcanabrava updated this revision to Diff 66258.Mon, Sep 16, 7:14 PM
  • Fix metadata installation
  • Fix model loading on Qml
  • Base work on the Qml
  • Name fixes
  • Move ui/main to contents
  • Fix wrong types in Qml
  • Plug the controllers
  • Link to the save button

Getting there!

Use an actual framed list view for the list of folders to not index, like the current one has.

mart accepted this revision.Tue, Sep 17, 10:14 AM
This revision is now accepted and ready to land.Tue, Sep 17, 10:14 AM
ngraham requested changes to this revision.Tue, Sep 17, 12:46 PM

This isn't ready yet without, at a minimum, the UI change I requested for the list view.

This revision now requires changes to proceed.Tue, Sep 17, 12:46 PM