Differential D23718 Diff 67563 kcms/baloo/package/contents/ui/main.qml

Changeset View

Standalone View

View Options

kcms/baloo/package/contents/ui/main.qml

  • This file was added.
1​/*
2​ * Copyright 2018 Kai Uwe Broulik <kde@privat.broulik.de>
3​ *
GB_2Unsubmitted
Done

Shouldn't this be you copyright?

GB_2: Shouldn't this be you copyright?
ngrahamUnsubmitted
Done

Not done yet

ngraham: Not done yet
4​ * This program is free software; you can redistribute it and/or
5​ * modify it under the terms of the GNU General Public License as
6​ * published by the Free Software Foundation; either version 2 of
7​ * the License or (at your option) version 3 or any later version
8​ * accepted by the membership of KDE e.V. (or its successor approved
9​ * by the membership of KDE e.V.), which shall act as a proxy
10​ * defined in Section 14 of version 3 of the license.
11​ *
12​ * This program is distributed in the hope that it will be useful,
13​ * but WITHOUT ANY WARRANTY; without even the implied warranty of
14​ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15​ * GNU General Public License for more details.
16​ *
17​ * You should have received a copy of the GNU General Public License
18​ * along with this program. If not, see <http://www.gnu.org/licenses/>.
19​ */
20​
21​import QtQuick 2.1
22​import QtQuick.Layouts 1.1
23​import QtQuick.Controls 2.12 as QQC2
ngrahamUnsubmitted
Done

IIRC plasma isn't depending on Qt 5.12 yet, right?

ngraham: IIRC plasma isn't depending on Qt 5.12 yet, right?
24​import QtQuick.Dialogs 1.2 as QtDialogs
25​import org.kde.kirigami 2.4 as Kirigami
26​import org.kde.kcm 1.1 as KCM
27​import Qt.labs.platform 1.1
28​
GB_2Unsubmitted
Not Done

Is this actually used? Also, because it's not installed by default it shows an error.

GB_2: Is this actually used? Also, because it's not installed by default it shows an error.
ngrahamUnsubmitted
Not Done

Fixed in https://commits.kde.org/plasma-desktop/659a46aac39789c40e8cd07060e3bacd5fe8d461

ngraham: Fixed in https://commits.kde.org/plasma-desktop/659a46aac39789c40e8cd07060e3bacd5fe8d461
29​KCM.SimpleKCM {
30​ id: root
31​
32​ KCM.ConfigModule.quickHelp: i18n("This module lets you configure the search in the system.")
33​ ColumnLayout {
ngrahamUnsubmitted
Done

"This module lets you configure the file indexer and search functionality."

ngraham: "This module lets you configure the file indexer and search functionality."
34​ anchors.fill: parent
35​ Layout.leftMargin: Kirigami.Units.smallSpacing * 2
36​ Layout.rightMargin: Kirigami.Units.smallSpacing * 2
37​
ngrahamUnsubmitted
Done

This item isn't inside a Layout, so Layout.<anything> has no effect. You want anchors.<whatever> instead.

Also the margins should be Kirigami.Units.largeSpacing.

ngraham: This item isn't inside a Layout, so `Layout.<anything>` has no effect. You want `anchors.
38​ QQC2.Label {
39​ text: i18n("File Search helps you quickly locate all your files based on their content")
ngrahamUnsubmitted
Done

This is a sentence, so it needs to end with a period.

ngraham: This is a sentence, so it needs to end with a period.
40​ }
41​
42​ QQC2.CheckBox {
43​ id: fileSearchEnabled
44​ text: i18n("Enable File Search")
45​
46​ onCheckStateChanged: {
47​ if (!checkState === Qt.Unchecked) {
ngrahamUnsubmitted
Not Done

This can be simplified to just if (!checked)

ngraham: This can be simplified to just `if (!checked)`
48​ indexFileContents.checked = false;
49​ }
50​ kcm.indexing = fileSearchEnabled.checked
ngrahamUnsubmitted
Not Done

Don't need to reference it with fileSearchEnabled, just do kcm.indexing = checked

ngraham: Don't need to reference it with `fileSearchEnabled`, just do `kcm.indexing = checked`
51​ }
52​
53​ Component.onCompleted : {
ngrahamUnsubmitted
Done

Don't do it this way, just use a binding:

checked: kcm.indexing

ngraham: Don't do it this way, just use a binding: `checked: kcm.indexing`
54​ fileSearchEnabled.checked = kcm.indexing ? Qt.Checked : Qt.Unchecked
55​ }
56​ }
57​
58​ QQC2.CheckBox {
59​ id: indexFileContents
60​ text: i18n("Also index file content")
61​ enabled: fileSearchEnabled.checked
62​
63​ onCheckStateChanged: {
64​ kcm.fileContents = indexFileContents.checkState === Qt.Checked
65​ }
66​
67​ Component.onCompleted : {
68​ indexFileContents.checked = kcm.fileContents ? Qt.Checked : Qt.Unchecked
69​ }
ngrahamUnsubmitted
Done

Same comments as with the first checkbox

ngraham: Same comments as with the first checkbox
70​ }
71​
ngrahamUnsubmitted
Done

I would add some spacing between the last checkbox and the list view's explanatory label:

Item {
    Layout.preferredHeight: Kirigami.Units.gridUnit
}
ngraham: I would add some spacing between the last checkbox and the list view's explanatory label: ```…
72​ QQC2.Label {
73​ text: "Do not search in these locations:"
74​ }
75​
76​ QQC2.ScrollView {
77​ id: bgObject
78​ Component.onCompleted: bgObject.background.visible = true
79​ Layout.fillWidth: true
80​ Layout.fillHeight: true
81​
82​ ListView {
83​ id: fileExcludeList
84​ anchors.fill: parent
85​
86​ model: kcm.filteredModel
87​ delegate: Kirigami.BasicListItem {
88​ icon: model.decoration
89​ label: model.folder
90​ onClicked: fileExcludeList.currentIndex = index
91​ }
92​ }
93​ }
94​
95​ RowLayout {
96​ QQC2.Button {
97​ id: addFolder
98​ icon.name: "list-add"
99​ onClicked: fileDialogLoader.active = true
100​ }
101​
102​ QQC2.Button{
103​ id: removeFolder
104​ icon.name: "list-remove"
105​ enabled: fileExcludeList.currentIndex !== -1
106​ onClicked: {
107​ kcm.filteredModel.removeFolder(fileExcludeList.currentIndex)
108​ }
109​ }
110​ }
111​ }
112​
113​ Loader {
114​ id: fileDialogLoader
115​ active: false
116​ sourceComponent: QtDialogs.FileDialog {
117​ title: i18n("Select a folder to filter")
118​ folder: shortcuts.home
119​ selectFolder: true
120​
121​ onAccepted: {
122​ kcm.filteredModel.addFolder(fileUrls[0])
123​ fileDialogLoader.active = false
124​ }
125​
126​ onRejected: {
127​ fileDialogLoader.active = false
128​ }
129​
130​ Component.onCompleted: open()
131​ }
132​ }
133​}