Differential D23718 Diff 66643 kcms/baloo/package/contents/ui/main.qml

Changeset View

Standalone View

kcms/baloo/package/contents/ui/main.qml

This file was added.

1		/*
2		* Copyright 2018 Kai Uwe Broulik <kde@privat.broulik.de>
	GB_2Unsubmitted Done Shouldn't this be you copyright? GB_2: Shouldn't this be you copyright?
	ngrahamUnsubmitted Done Not done yet ngraham: Not done yet
3		*
4		* This program is free software; you can redistribute it and/or
5		* modify it under the terms of the GNU General Public License as
6		* published by the Free Software Foundation; either version 2 of
7		* the License or (at your option) version 3 or any later version
8		* accepted by the membership of KDE e.V. (or its successor approved
9		* by the membership of KDE e.V.), which shall act as a proxy
10		* defined in Section 14 of version 3 of the license.
11		*
12		* This program is distributed in the hope that it will be useful,
13		* but WITHOUT ANY WARRANTY; without even the implied warranty of
14		* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15		* GNU General Public License for more details.
16		*
17		* You should have received a copy of the GNU General Public License
18		* along with this program. If not, see <http://www.gnu.org/licenses/>.
19		*/
20
21		import QtQuick 2.1
22		import QtQuick.Layouts 1.1
23		import QtQuick.Controls 2.12 as QQC2
24		import QtQuick.Dialogs 1.2 as QtDialogs
	ngrahamUnsubmitted Done IIRC plasma isn't depending on Qt 5.12 yet, right? ngraham: IIRC plasma isn't depending on Qt 5.12 yet, right?
25		import org.kde.kirigami 2.4 as Kirigami
26		import org.kde.kcm 1.1 as KCM
27		import Qt.labs.platform 1.1
28
	GB_2Unsubmitted Not Done Is this actually used? Also, because it's not installed by default it shows an error. GB_2: Is this actually used? Also, because it's not installed by default it shows an error.
	ngrahamUnsubmitted Not Done Fixed in https://commits.kde.org/plasma-desktop/659a46aac39789c40e8cd07060e3bacd5fe8d461 ngraham: Fixed in https://commits.kde.org/plasma-desktop/659a46aac39789c40e8cd07060e3bacd5fe8d461
29		KCM.SimpleKCM {
30		id: root
31
32		KCM.ConfigModule.quickHelp: i18n("This module lets you configure the search in the system.")
33		ColumnLayout {
	ngrahamUnsubmitted Done "This module lets you configure the file indexer and search functionality." ngraham: "This module lets you configure the file indexer and search functionality."
34		anchors.fill: parent
35
36		QQC2.Label {
37		text: i18n("File Search helps you quickly locate all your files based on their content")
	ngrahamUnsubmitted Done This item isn't inside a Layout, so `Layout.<anything>` has no effect. You want `anchors.<whatever>` instead. Also the margins should be `Kirigami.Units.largeSpacing`. ngraham: This item isn't inside a Layout, so `Layout.<anything>` has no effect. You want `anchors.
38		}
39
40		QQC2.CheckBox {
	ngrahamUnsubmitted Done This is a sentence, so it needs to end with a period. ngraham: This is a sentence, so it needs to end with a period.
41		id: fileSearchEnabled
42		text: i18n("Enable File Search")
43
44		onCheckStateChanged: {
45		if (!checkState === Qt.Unchecked) {
46		indexFileContents.checked = false;
47		}
48		kcm.indexing = fileSearchEnabled.checked
	ngrahamUnsubmitted Not Done This can be simplified to just `if (!checked)` ngraham: This can be simplified to just `if (!checked)`
49		}
50
51		Component.onCompleted : {
	ngrahamUnsubmitted Not Done Don't need to reference it with `fileSearchEnabled`, just do `kcm.indexing = checked` ngraham: Don't need to reference it with `fileSearchEnabled`, just do `kcm.indexing = checked`
52		fileSearchEnabled.checked = kcm.indexing ? Qt.Checked : Qt.Unchecked
53		}
54		}
	ngrahamUnsubmitted Done Don't do it this way, just use a binding: `checked: kcm.indexing` ngraham: Don't do it this way, just use a binding: `checked: kcm.indexing`
55
56		QQC2.CheckBox {
57		id: indexFileContents
58		text: i18n("Also index file content")
59		enabled: fileSearchEnabled.checked
60
61		onCheckStateChanged: {
62		kcm.fileContents = indexFileContents.checkState === Qt.Checked
63		}
64
65		Component.onCompleted : {
66		indexFileContents.checked = kcm.fileContents ? Qt.Checked : Qt.Unchecked
67		}
68		}
69
70		QQC2.Label {
	ngrahamUnsubmitted Done Same comments as with the first checkbox ngraham: Same comments as with the first checkbox
71		text: "Do not search in these locations:"
72		}
	ngrahamUnsubmitted Done I would add some spacing between the last checkbox and the list view's explanatory label: Item { Layout.preferredHeight: Kirigami.Units.gridUnit } ngraham: I would add some spacing between the last checkbox and the list view's explanatory label: ```…
73
74		QQC2.ScrollView {
75		id: bgObject
76		Component.onCompleted: bgObject.background.visible = true
77		Layout.fillWidth: true
78		Layout.fillHeight: true
79		Layout.leftMargin: Kirigami.Units.smallSpacing * 2
80		Layout.rightMargin: Kirigami.Units.smallSpacing * 2
81
82		ListView {
83		id: fileExcludeList
84		anchors.fill: parent
85
86		model: kcm.filteredModel
87		highlight: Rectangle { color: "lightsteelblue" }
88		focus: true
89
90		delegate: MouseArea {
91		width: fileExcludeList.width
92		height: childrenRect.height
93
94		Image {
95		source: model.DecorationRole ? model.DecorationRole : ""
96		}
97		QQC2.Label {
98		text: model.Folder
99		}
100		onClicked: {
101		fileExcludeList.currentIndex = index
102		}
103		}
104
105		Component.onCompleted : {
106		fileExcludeList.currentIndex = -1
107		}
108		}
109		}
110
111		RowLayout {
112		QQC2.Button {
113		id: addFolder
114		icon.name: "list-add"
115		onClicked: fileDialogLoader.active = true
116		}
117
118		QQC2.Button{
119		id: removeFolder
120		icon.name: "list-remove"
121		enabled: fileExcludeList.currentIndex !== -1
122		onClicked: {
123		kcm.filteredModel.removeFolder(fileExcludeList.currentIndex)
124		}
125		}
126		}
127		}
128
129		Loader {
130		id: fileDialogLoader
131		active: false
132		sourceComponent: QtDialogs.FileDialog {
133		title: i18n("Select a folder to filter")
134		folder: shortcuts.home
135		selectFolder: true
136
137		onAccepted: {
138		kcm.filteredModel.addFolder(fileUrls[0])
139		fileDialogLoader.active = false
140		}
141
142		onRejected: {
143		fileDialogLoader.active = false
144		}
145
146		Component.onCompleted: open()
147		}
148		}
149		}