Changeset View
Standalone View
src/dolphinmainwindow.cpp
| Show First 20 Lines • Show All 181 Lines • ▼ Show 20 Line(s) | 111 | { | |||
|---|---|---|---|---|---|
| 182 | } | 182 | } | ||
| 183 | 183 | | |||
| 184 | // enable middle-click on back/forward/up to open in a new tab | 184 | // enable middle-click on back/forward/up to open in a new tab | ||
| 185 | auto *middleClickEventFilter = new MiddleClickActionEventFilter(this); | 185 | auto *middleClickEventFilter = new MiddleClickActionEventFilter(this); | ||
| 186 | connect(middleClickEventFilter, &MiddleClickActionEventFilter::actionMiddleClicked, this, &DolphinMainWindow::slotToolBarActionMiddleClicked); | 186 | connect(middleClickEventFilter, &MiddleClickActionEventFilter::actionMiddleClicked, this, &DolphinMainWindow::slotToolBarActionMiddleClicked); | ||
| 187 | toolBar()->installEventFilter(middleClickEventFilter); | 187 | toolBar()->installEventFilter(middleClickEventFilter); | ||
| 188 | 188 | | |||
| 189 | setupWhatsThis(); | 189 | setupWhatsThis(); | ||
| 190 | | ||||
| 191 | // Restore window state if the setting is turned on and there are no | ||||
| 192 | // other Dolphin windows open | ||||
| 193 | if (GeneralSettings::rememberOpenedTabs()) { | ||||
broulik: Instead of hardcoding those settings everywhere, please use KConfigXt (the `kcfg` files you can… | |||||
you need to check you're not being loaded as part of a session restore otherwise you'll have two paths call readProperties qApp->isSessionRestored() davidedmundson: you need to check you're not being loaded as part of a session restore otherwise you'll have… | |||||
| 194 | // Check for existing Dolphin windows in a separate nested if() to | ||||
| 195 | // save a DBus call if the user isn't using the feature | ||||
| 196 | // FIXME: Calling Dolphin::dolphinInstanceData() here is slooooooooow | ||||
| 197 | if (Dolphin::dolphinInstanceData(QStringLiteral("org.kde.dolphin-%1").arg(QCoreApplication::applicationPid())).isEmpty()) { | ||||
I'm surprised this works at all. AFAICTL it'll never be empty as the instance will find itself and hence won't be empty, unless our DBus interface isn't initialised yet (tbf I don't know when it would be). Either way I don't see why this instance is preferred so I think the code would be clearer if it was simply QString() instead. feverfew: I'm surprised this works at all. AFAICTL it'll never be empty as the instance will find itself… | |||||
It doesn't find itself because Dolphin::dolphinInstanceData() filters out the currently running instance by excludinv entries that match its PID. ngraham: It doesn't find itself because `Dolphin::dolphinInstanceData()` filters out the currently… | |||||
The reason why preferredService was a parameter was for when ShowFolders/ShowItems was called via DBus. It specifically bypasses excluding the running instance as in that case you wanted the running instance to accept those URLs, i.e. marking a sevice as preferred means it is exempt from the check that filters out the currently running instance. In this case you want to see if any other instances (apart from this one) exist, and hence you should be passing QString(). The only reason I can think of why the patch works in this current state is that Q_CLASSINFO macro only initialises the DBus object for the main window after the constructor finishes... feverfew: The reason why `preferredService` was a parameter was for when `ShowFolders`/`ShowItems` was… | |||||
| 198 | // Wait for the initialization ending | ||||
| 199 | QTimer::singleShot(0, [this]() { | ||||
| 200 | KConfigGroup windowState{KSharedConfig::openConfig(QStringLiteral("dolphinrc")), "WindowState"}; | ||||
| 201 | readProperties(windowState); | ||||
| 202 | }); | ||||
| 203 | } | ||||
| 204 | } | ||||
| 190 | } | 205 | } | ||
| 191 | 206 | | |||
| 192 | DolphinMainWindow::~DolphinMainWindow() | 207 | DolphinMainWindow::~DolphinMainWindow() | ||
| 193 | { | 208 | { | ||
| 194 | } | 209 | } | ||
| 195 | 210 | | |||
| 196 | QVector<DolphinViewContainer*> DolphinMainWindow::viewContainers() const | 211 | QVector<DolphinViewContainer*> DolphinMainWindow::viewContainers() const | ||
| 197 | { | 212 | { | ||
| 198 | QVector<DolphinViewContainer*> viewContainers; | 213 | QVector<DolphinViewContainer*> viewContainers; | ||
| 199 | viewContainers.reserve(m_tabWidget->count()); | 214 | viewContainers.reserve(m_tabWidget->count()); | ||
| 200 | for (int i = 0; i < m_tabWidget->count(); ++i) { | 215 | for (int i = 0; i < m_tabWidget->count(); ++i) { | ||
elvisangelaccio: Please move this logic in `DolphinMainWindow::closeEvent()`. | |||||
| 201 | viewContainers << m_tabWidget->tabPageAt(i)->activeViewContainer(); | 216 | viewContainers << m_tabWidget->tabPageAt(i)->activeViewContainer(); | ||
| 202 | } | 217 | } | ||
| 203 | return viewContainers; | 218 | return viewContainers; | ||
| 204 | } | 219 | } | ||
| 205 | 220 | | |||
| 206 | void DolphinMainWindow::openDirectories(const QList<QUrl>& dirs, bool splitView) | 221 | void DolphinMainWindow::openDirectories(const QList<QUrl>& dirs, bool splitView) | ||
| 207 | { | 222 | { | ||
| 208 | m_tabWidget->openDirectories(dirs, splitView); | 223 | m_tabWidget->openDirectories(dirs, splitView); | ||
| ▲ Show 20 Lines • Show All 347 Lines • ▼ Show 20 Line(s) | 569 | case QDialogButtonBox::No: | |||
| 556 | // Do not quit, ignore quit event | 571 | // Do not quit, ignore quit event | ||
| 557 | Q_FALLTHROUGH(); | 572 | Q_FALLTHROUGH(); | ||
| 558 | default: | 573 | default: | ||
| 559 | event->ignore(); | 574 | event->ignore(); | ||
| 560 | return; | 575 | return; | ||
| 561 | } | 576 | } | ||
| 562 | } | 577 | } | ||
| 563 | 578 | | |||
| 579 | if (GeneralSettings::rememberOpenedTabs()) { | ||||
| 580 | KConfigGroup windowState{KSharedConfig::openConfig(QStringLiteral("dolphinrc")), "WindowState"}; | ||||
| 581 | saveProperties(windowState); | ||||
| 582 | } | ||||
| 583 | | ||||
| 564 | GeneralSettings::setVersion(CurrentDolphinVersion); | 584 | GeneralSettings::setVersion(CurrentDolphinVersion); | ||
| 565 | GeneralSettings::self()->save(); | 585 | GeneralSettings::self()->save(); | ||
| 566 | 586 | | |||
| 567 | KXmlGuiWindow::closeEvent(event); | 587 | KXmlGuiWindow::closeEvent(event); | ||
| 568 | } | 588 | } | ||
| 569 | 589 | | |||
| 570 | void DolphinMainWindow::saveProperties(KConfigGroup& group) | 590 | void DolphinMainWindow::saveProperties(KConfigGroup& group) | ||
| 571 | { | 591 | { | ||
| ▲ Show 20 Lines • Show All 1597 Lines • Show Last 20 Lines | |||||
Instead of hardcoding those settings everywhere, please use KConfigXt (the kcfg files you can see for other places in Dolphin), like GeneralSettings