Changeset View
Changeset View
Standalone View
Standalone View
src/kcm/module.cpp
Show All 30 Lines | |||||
31 | #include "version.h" | 31 | #include "version.h" | ||
32 | 32 | | |||
33 | K_PLUGIN_CLASS_WITH_JSON(KCMPulseAudio, "kcm_pulseaudio.json") | 33 | K_PLUGIN_CLASS_WITH_JSON(KCMPulseAudio, "kcm_pulseaudio.json") | ||
34 | 34 | | |||
35 | KCMPulseAudio::KCMPulseAudio(QObject *parent, const QVariantList &args) | 35 | KCMPulseAudio::KCMPulseAudio(QObject *parent, const QVariantList &args) | ||
36 | : KQuickAddons::ConfigModule(parent, args) | 36 | : KQuickAddons::ConfigModule(parent, args) | ||
37 | { | 37 | { | ||
38 | KAboutData *aboutData = new KAboutData("kcm_pulseaudio", | 38 | KAboutData *aboutData = new KAboutData("kcm_pulseaudio", | ||
39 | i18nc("@title", "Configure the Audio Volume"), | 39 | i18nc("@title", "Audio"), | ||
ndavis: Why are we changing the title to just "Audio"? Weren't we supposed to use descriptions for the… | |||||
Our conclusion before was to make the page title match the title listed in the desktop file, and the comment has a description. You can see this in all the KCMs in the Appearance section This seems semantically correct, and if we want to display the descriptive string, we should change KPageDialog or something in KCMUtils to parse the comment in the desktop file and display it underneath the title. Frankly that should happen anyway so we don't have to define the same string for the title in both the desktop file and also the kaboutdata. ngraham: Our conclusion before was to make the page title match the title listed in the desktop file… | |||||
40 | global_s_versionStringFull, | 40 | global_s_versionStringFull, | ||
41 | QStringLiteral(""), | 41 | QStringLiteral(""), | ||
42 | KAboutLicense::LicenseKey::GPL_V3, | 42 | KAboutLicense::LicenseKey::GPL_V3, | ||
43 | i18nc("@info:credit", "Copyright 2015 Harald Sitter")); | 43 | i18nc("@info:credit", "Copyright 2015 Harald Sitter")); | ||
44 | 44 | | |||
45 | aboutData->addAuthor(i18nc("@info:credit", "Harald Sitter"), | 45 | aboutData->addAuthor(i18nc("@info:credit", "Harald Sitter"), | ||
46 | i18nc("@info:credit", "Author"), | 46 | i18nc("@info:credit", "Author"), | ||
47 | QStringLiteral("apachelogger@kubuntu.org")); | 47 | QStringLiteral("apachelogger@kubuntu.org")); | ||
Show All 22 Lines |
Why are we changing the title to just "Audio"? Weren't we supposed to use descriptions for the page titles to make them useful? Am I mistaken?