Changeset View
Changeset View
Standalone View
Standalone View
src/query.h
Show First 20 Lines • Show All 92 Lines • ▼ Show 20 Line(s) | 70 | public: | |||
---|---|---|---|---|---|
93 | QDate dateEnd() const; | 93 | QDate dateEnd() const; | ||
94 | 94 | | |||
95 | void setSelection(Terms::Select selection); | 95 | void setSelection(Terms::Select selection); | ||
96 | 96 | | |||
97 | void addTypes(const QStringList &types); | 97 | void addTypes(const QStringList &types); | ||
98 | void addAgents(const QStringList &agents); | 98 | void addAgents(const QStringList &agents); | ||
99 | void addActivities(const QStringList &activities); | 99 | void addActivities(const QStringList &activities); | ||
100 | void addUrlFilters(const QStringList &urlFilters); | 100 | void addUrlFilters(const QStringList &urlFilters); | ||
101 | void setType(const Terms::Type &types); | ||||
kossebau: Please add "@since 6.62" to all this new API, so consumers of them know which min version of… | |||||
kossebau: "5.62" of course :) | |||||
Thanks D23555 meven: Thanks D23555 | |||||
102 | void setAgent(const Terms::Agent &agents); | ||||
103 | void setActivity(const Terms::Activity &activities); | ||||
104 | void setUrlFilter(const Terms::Url &urlFilters); | ||||
101 | void setOrdering(Terms::Order ordering); | 105 | void setOrdering(Terms::Order ordering); | ||
I screwed up the names - plurals vs singulars here as Agent can contain several agents - having Agent::current looked better than Agents::current. We'll need to do something about this for Qt6/KF6. Now, I can not guarantee this, but I think we will have a smaller API change if these were all named in plural. In that case, with the implicit conversion from QStringList to Agent and others, only one set function should be needed for each of these. So void setTypes(const Terms::Type &types); instead of void setTypes(const QStringList &types); void setType(const Terms::Type &types); What do you think? ivan: I screwed up the names - plurals vs singulars here as `Agent` can contain several agents… | |||||
meven: That works | |||||
102 | void setOffset(int offset); | 106 | void setOffset(int offset); | ||
103 | void setLimit(int limit); | 107 | void setLimit(int limit); | ||
104 | void setDateStart(QDate date); | 108 | void setDateStart(QDate date); | ||
105 | void setDateEnd(QDate date); | 109 | void setDateEnd(QDate date); | ||
106 | 110 | | |||
107 | void clearTypes(); | 111 | void clearTypes(); | ||
108 | void clearAgents(); | 112 | void clearAgents(); | ||
109 | void clearActivities(); | 113 | void clearActivities(); | ||
▲ Show 20 Lines • Show All 92 Lines • Show Last 20 Lines |
Please add "@since 6.62" to all this new API, so consumers of them know which min version of KActivitiesStat they need to require to be able to rely on their existance.