Differential D22889 Diff 64350 src/util/externalcommand_polkitbackend.cpp

Changeset View

Standalone View

src/util/externalcommand_polkitbackend.cpp

This file was added.

1		/*************************************************************************
2		* Copyright (C) 2019 by Shubham <aryan100jangid@gmail.com> *
3		* *
4		* This program is free software; you can redistribute it and/or *
5		* modify it under the terms of the GNU General Public License as *
6		* published by the Free Software Foundation; either version 3 of *
7		* the License, or (at your option) any later version. *
8		* *
9		* This program is distributed in the hope that it will be useful, *
10		* but WITHOUT ANY WARRANTY; without even the implied warranty of *
11		* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the *
12		* GNU General Public License for more details. *
13		* *
14		* You should have received a copy of the GNU General Public License *
15		* along with this program. If not, see <http://www.gnu.org/licenses/>.*
16		*************************************************************************/
17
18		#include "util/externalcommand_polkitbackend.h"
19
20		#include <QApplication>
21		#include <QtDBus>
22		#include <QDebug>
23		#include <QEventLoop>
24		#include <QString>
25		#include <QTimer>
26		#include <QWidget>
27
28		#include <PolkitQt1/Authority>
29		#include <PolkitQt1/Subject>
30
31		using namespace PolkitQt1;
32
33		Authority::Result Auth::PolkitEventLoop::m_result = Authority::No;
34
35		namespace Auth
36		{
37
38		PolkitEventLoop::PolkitEventLoop(QObject *parent)
39		: QEventLoop(qobject_cast<QEventLoop *>(parent))
40		{
41
42		}
43
44		PolkitEventLoop::~PolkitEventLoop()
45		{
46
47		}
48
49		void PolkitEventLoop::requestQuit(const Authority::Result &result)
50		{
51		m_result = result;
52		quit();
53		}
54
55		Authority::Result PolkitEventLoop::result() const
56		{
57		return m_result;
58		}
59
60		PolkitQt1Backend::PolkitQt1Backend()
61		: m_flyingActions(false)
62		{
63		// Connect various useful Polkit signals
64		connect(Authority::instance(), &Authority::configChanged, this, &Auth::PolkitQt1Backend::authStatusChanged);
65		connect(Authority::instance(), &Authority::consoleKitDBChanged, this, &Auth::PolkitQt1Backend::authStatusChanged);
66
67		m_flyingActions = true;
68		PolkitQt1::Authority::instance()->enumerateActions();
69		}
70
71		PolkitQt1Backend::~PolkitQt1Backend()
72		{
73
74		}
75
76		void PolkitQt1Backend::startHelper(const QString &action, const QString &helperID, int timeout /10 days/)
77		{
78		QDBusMessage message = QDBusMessage::createMethodCall(helperID, QStringLiteral("/Helper"), QStringLiteral("org.kde.kpmcore.helperinterface"), QStringLiteral("performAction"));
79
80		const QByteArray caller = QDBusConnection::systemBus().baseService().toUtf8();
81		QList<QVariant> args;
82		args << action << caller;
83		message.setArguments(args);
84
85		QDBusPendingCall pendingCall = QDBusConnection::systemBus().asyncCall(message, timeout);
86
87		auto watcher = new QDBusPendingCallWatcher(pendingCall);
88
89		QObject::connect(watcher, &QDBusPendingCallWatcher::finished, this, [this, action, watcher]() {
90		watcher->deleteLater();
91
92		const QDBusMessage reply = watcher->reply();
93
94		if (reply.type() == QDBusMessage::ErrorMessage) {
95		qWarning() << "Failed to contact the helper, Error message:" << reply.errorMessage();
96		}
97		});
98		}
99
100		void PolkitQt1Backend::initPolkitAgent(const QString &action, QWidget parent /= nullptr*/) const
101		{
102		if (!parent) {
103		qWarning() << "Parent widget does not exists, can not proceed further";
104		return;
105		}
106
107		// Check if we are running terminal session or GUI session
108		if (!qApp) {
	stikonasUnsubmitted Done Why do we need connect to finished signal if in the line above you wait for call to finish with `call.waitForFinished()` that function blocks until call is done. stikonas: Why do we need connect to finished signal if in the line above you wait for call to finish with…
109		qWarning() << "We are running a TTY (Terminal) session";
110		qDebug() << "Can not proceed further since we do not support Text based Polkit Authentication Agent";
111		return;
112		}
113
114		// Get the dialog parent window Id
115		quint64 parentWindowID = parent->effectiveWinId();
116
117		// Make a call to the KDE polkit Authentication Agent asking for it's services
118		QDBusMessage callAgent = QDBusMessage::createMethodCall(QStringLiteral("org.kde.polkit-kde-authentication-agent-1"), QStringLiteral("/org/kde/Polkit1AuthAgent"), QStringLiteral("org.kde.Polkit1AuthAgent"),
119		QStringLiteral("setWIdForAction"));
120
121		callAgent << action;
122		callAgent << parentWindowID;
123
124		QDBusPendingCall call = QDBusConnection::sessionBus().asyncCall(callAgent);
125
126		auto watcher = new QDBusPendingCallWatcher(call);
127
128		connect(watcher, &QDBusPendingCallWatcher::finished, this, [this, action, watcher](){
129		watcher->deleteLater();
130		const QDBusMessage reply = watcher->reply();
131
132		if (reply.type() == QDBusMessage::ErrorMessage) {
133		qWarning() << "Could not call the Authentication Agent, Error:" << reply.errorMessage();
134		}
135		});
136		}
137
138		Authority::Result PolkitQt1Backend::actionStatus(const QString &action, const QByteArray &callerID) const
139		{
140		SystemBusNameSubject subject(QString::fromUtf8(callerID));
141
142		auto authority = Authority::instance();
143
144		PolkitEventLoop::m_result = authority->checkAuthorizationSync(action, subject, Authority::None);
145
146		if (authority->hasError()) {
147		qDebug() << "Encountered error while checking action status, Error code:" << authority->lastError() << "\n";
148		qDebug() << "Error Details:" << authority->errorDetails();
149		authority->clearError();
150		}
151
152		return PolkitEventLoop::m_result;
153		}
154
155		QByteArray PolkitQt1Backend::callerID() const
156		{
157		return QDBusConnection::systemBus().baseService().toUtf8();
	stikonasUnsubmitted Done What sets `m_result`? in the connect call above you simply pass result to QEventLoop's function quit without processing it. stikonas: What sets `m_result`? in the connect call above you simply pass result to QEventLoop's function…
	shubhamAuthorUnsubmitted Not Done Actually yes, it is currently broke, however it does not matter, because I am just using this function to show the auth agent and if you notice line 383 externalcommand.cpp, to display some log message. Oh, now I get why it was reporting ""Unable to obtain Administrative privileges, the action can not be executed!!";" shubham: Actually yes, it is currently broke, however it does not matter, because I am just using this…
158		}
159
160		bool PolkitQt1Backend::authorizeAction(const QString &action, const QByteArray &callerID)
161		{
162		SystemBusNameSubject subject(QString::fromUtf8(callerID));
163
164		auto authority = Authority::instance();
165
166		PolkitEventLoop event;
167		event.processEvents();
168
169		connect(authority, &Authority::checkAuthorizationFinished, &event, &PolkitEventLoop::requestQuit);
170		authority->checkAuthorizationSync(action, subject, Authority::AllowUserInteraction);
171
172		event.exec();
173
174		if (authority->hasError()) {
175		qWarning() << "Encountered error while checking authorization, Error code:" << authority->lastError() << "\n";
176		qDebug() << "Error details:" << authority->errorDetails();
177
178		// Clear all the errors from the buffer so that hasError() does not give previous error as a result when called later
179		authority->clearError();
180		}
181
182		if (event.result() /PolkitEventLoop::m_result/ == Authority::Yes) {
183		return true;
184		} else {
185		return false;
186		}
187		}
188
189		bool PolkitQt1Backend::revokeAuthorization(const QString &action, const QByteArray &callerID)
190		{
191		Q_UNUSED(action)
192
193		SystemBusNameSubject subject(QString::fromUtf8(callerID));
194
195		auto authority = Authority::instance();
196
197		return authority->revokeTemporaryAuthorizationsSync(subject);
198		}
199
200		void PolkitQt1Backend::authStatusChanged()
201		{
202		for (auto it = m_cachedResults.begin(); it != m_cachedResults.end(); ++it) {
203		const QString action = it.key();
204		QByteArray pid = QDBusConnection::systemBus().baseService().toUtf8();
205		if (it.value() != actionStatus(action, pid)) {
206		*it = actionStatus(action, pid);
207		}
208		}
209
210		// Force updating known actions
211		Authority::instance()->enumerateActions();
212		m_flyingActions = true;
213		}
214
215		} // namespace Auth