Differential D23343 Diff 64335 src/project/projectwidget.cpp

Changeset View

Standalone View

View Options

src/project/projectwidget.cpp

Show First 20 Lines • Show All 389 Lines • ▼ Show 20 Line(s)389{
390 if (!m_proxyModel->filterAcceptsRow(idx.row(), idx.parent())) { 390​ if (!m_proxyModel->filterAcceptsRow(idx.row(), idx.parent())) {
391 return; 391​ return;
392 } 392​ }
393 ProjectModel& model = *(Project::instance()->model()); 393​ ProjectModel& model = *(Project::instance()->model());
394 const KFileItem& item(model.itemForIndex(idx)); 394​ const KFileItem& item(model.itemForIndex(idx));
395 if (item.isDir()) { 395​ if (item.isDir()) {
396 int j = model.rowCount(idx); 396​ int j = model.rowCount(idx);
397 while (--j >= 0) { 397​ while (--j >= 0) {
398 const KFileItem& childItem(model.itemForIndex(idx.child(j, 0))); 398​ const KFileItem& childItem(model.itemForIndex(model.index(j, 0, idx)));
aacidUnsubmitted
Not Done

is idx.model() just "model" here? i think it'd make more sense to use that here and below, could you check if that's the case?

aacid: is idx.model() just "model" here? i think it'd make more sense to use that here and below…
399 399​
400 if (childItem.isDir()) 400​ if (childItem.isDir())
401 recursiveAdd(list, idx.child(j, 0)); 401​ recursiveAdd(list, model.index(j, 0, idx));
402 else if (m_proxyModel->filterAcceptsRow(j, idx)) 402​ else if (m_proxyModel->filterAcceptsRow(j, idx))
403 list.prepend(childItem.localPath()); 403​ list.prepend(childItem.localPath());
404 } 404​ }
405 } else //if (!list.contains(u)) 405​ } else //if (!list.contains(u))
406 list.prepend(item.localPath()); 406​ list.prepend(item.localPath());
407} 407​}
408 408​
409QStringList ProjectWidget::selectedItems() const 409​QStringList ProjectWidget::selectedItems() const
▲ Show 20 Lines • Show All 142 Lines • Show Last 20 Lines